Add xml comments to HubInvocationContext #11683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
analogrelay,
halter73 and
mikaelm12
as code owners
Co-Authored-By: Andrew Stanton-Nurse <[email protected]>
mikaelm12
approved these changes
Jun 28, 2019
| /// <summary> | ||
| /// Instantiates a new instance of the <see cref="HubInvocationContext"/> class. | ||
| /// </summary> | ||
| /// <param name="context">Context for the active hub connection and caller.</param> |
There was a problem hiding this comment.
nit:Should this be "hub connection" or HubConnection?
There was a problem hiding this comment.
I don't think it should be HubConnection as that is the client side type, on the server it's a "connection to a hub" i.e. "hub connection". But I could be convinced either way
| public HubInvocationContext(HubCallerContext context, string hubMethodName, object[] hubMethodArguments) | ||
| { | ||
| HubMethodName = hubMethodName; | ||
| HubMethodArguments = hubMethodArguments; | ||
| Context = context; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets the context for the active hub connection and caller. |
halter73
approved these changes
Jun 28, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the word-smithing begin!