Skip to content

Move Blazor HttpClient functionality out of sfx #11767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2019
Merged

Move Blazor HttpClient functionality out of sfx #11767

merged 1 commit into from
Jul 2, 2019

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Jul 1, 2019

Fixes: #11756 #10505

See description in #11756

@rynowak rynowak requested a review from a team as a code owner July 1, 2019 21:12
@rynowak rynowak force-pushed the rynowak/blazor-http branch from 97062cd to 3edee75 Compare July 1, 2019 22:39
dougbu
dougbu reviewed Jul 1, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this looks fine to me.

Just curious: Why do we need to ship this class separately, is there an issue tracking this change, and does it need to happen in preview 7?

@rynowak
Copy link
Member Author

rynowak commented Jul 1, 2019

Just curious: Why do we need to ship this class separately, is there an issue tracking this change, and does it need to happen in preview 7?

The issue is linked in the description.

@Eilon Eilon added the area-blazor Includes: Blazor, Razor Components label Jul 1, 2019
@rynowak rynowak merged commit 8a7508d into master Jul 2, 2019
@ghost ghost deleted the rynowak/blazor-http branch July 2, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu left review comments

@pranavkm pranavkm pranavkm approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blazor API Review: HttpClient functionality
4 participants
@rynowak @pranavkm @dougbu @Eilon