Blazor API Review: Design concept for Dispatcher #11930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
commented
Jul 5, 2019
rynowak
commented
Jul 5, 2019
rynowak
commented
Jul 5, 2019
rynowak
commented
Jul 5, 2019
rynowak
commented
Jul 5, 2019
rynowak
force-pushed
the
rynowak/dispatcher
branch
from
7fb03db to
7be0efc
Compare
campersau
reviewed
Jul 6, 2019
src/Components/Components/src/Rendering/RendererSynchronizationContextDispatcher.cs
Show resolved
Hide resolved
|
Besides the questions about initialization, this looks like a great direction to go in! |
davidfowl
reviewed
Jul 8, 2019
src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.cs
Show resolved
Hide resolved
davidfowl
reviewed
Jul 8, 2019
rynowak
commented
Jul 8, 2019
src/Components/Components/src/Rendering/RendererSynchronizationContextDispatcher.cs
Show resolved
Hide resolved
rynowak
force-pushed
the
rynowak/dispatcher
branch
from
7be0efc to
21535cd
Compare
rynowak
commented
Jul 9, 2019
src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.cs
Show resolved
Hide resolved
rynowak
commented
Jul 9, 2019
src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.cs
Show resolved
Hide resolved
rynowak
force-pushed
the
rynowak/dispatcher
branch
from
21535cd to
9e9fd5a
Compare
|
@SteveSandersonMS - can I get an updoot from you if you're happy with this? |
SteveSandersonMS
approved these changes
Jul 11, 2019
Part of: #11610 This change brings forward the Dispatcher as a more primary and more expandable concept. - Dispatcher shows up in more places - Dispatcher is an abstract class for horizontal scalability - Dispatcher has parallels with S.Windows.Threading.Dispatcher where possible Looking for feedback on this approach. I feel pretty strongly that making this an abstract class is the right choice, I want to see opinions on how much to push it into people's faces.
rynowak
force-pushed
the
rynowak/dispatcher
branch
from
9e9fd5a to
06468ee
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #11610
This change brings forward the Dispatcher as a more primary and more
expandable concept.
possible
Looking for feedback on this approach. I feel pretty strongly that
making this an abstract class is the right choice, I want to see
opinions on how much to push it into people's faces.