Skip to content

Let's see if this runs tests on Debug builds #12292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

halter73
Copy link
Member

Hopefully this eventually addresses #11632

@halter73 halter73 requested a review from a team as a code owner July 17, 2019 23:07
@halter73 halter73 requested a review from analogrelay July 17, 2019 23:07
@halter73 halter73 force-pushed the halter73/test-debug branch from de960ff to 563ab1e Compare July 17, 2019 23:15
@@ -394,6 +394,29 @@ jobs:
path: artifacts/TestResults/
publishOnError: true

- template: jobs/default-build.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will run in every build, PR or not. Suggest creating a build matrix in the Test Windows Server 2016 x64 job and make the Debug side of it conditional on it not being a PR build, then use $(_BuildConfig) instead of Release where necessary.

Overall, this is kind of the opposite of what we do in https://github.com/aspnet/Extensions. Extensions code of interest is https://github.com/aspnet/Extensions/blob/8385543edac69a2b817756d1ba81a63acf76518d/azure-pipelines.yml#L78-L88.

In particular, I'm suggesting

strategy:
  matrix:
    ${{ if notin(variables['Build.Reason'], 'PullRequest') }}:
      Debug:
        _BuildConfig: Debug
    Release:
      _BuildConfig: Release

Could also only do the Debug side of the matrix in (say) internal builds. Up to you.

And, could add a schedule for this pipeline (avoiding something totally separate) and use in(variables['Build.Reason'], 'PullRequest') as the condition above to only build Debug daily (for example).

@analogrelay analogrelay added this to the 3.0.0-preview8 milestone Jul 18, 2019
@analogrelay analogrelay added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed area-servers labels Jul 18, 2019
@analogrelay
Copy link
Contributor

Just make sure you update the title when you're ready so I'm not sending Tactics a tell-mode email for a PR titled "Let's see if..." 😛

@halter73
Copy link
Member Author

Just make sure you update the title when you're ready so I'm not sending Tactics a tell-mode email for a PR titled "Let's see if..."

Noted. If I thought about it more, I would have made this a draft. I could close and reopen as a draft if you want.

@analogrelay
Copy link
Contributor

Nah, it only matters if/when you merge it ;P

@analogrelay analogrelay modified the milestone: 3.0.0-preview8 Jul 23, 2019
@analogrelay analogrelay added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 23, 2019
@halter73 halter73 force-pushed the halter73/test-debug branch from 07521f9 to 58cd02d Compare August 15, 2019 22:16
@halter73 halter73 changed the base branch from master to release/3.0 August 15, 2019 22:49
@halter73 halter73 removed the request for review from SteveSandersonMS August 15, 2019 22:49
@halter73 halter73 force-pushed the halter73/test-debug branch from 58cd02d to f3cff72 Compare August 21, 2019 17:41
@Pilchie Pilchie modified the milestones: 3.0.0-preview9, 3.0.0 Sep 7, 2019
@analogrelay analogrelay removed this from the 3.0.0 milestone Oct 17, 2019
@analogrelay
Copy link
Contributor

Closing as this is stale now. We can retarget to master if we still want to do this.

@dougbu dougbu deleted the halter73/test-debug branch May 18, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants