-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Let's see if this runs tests on Debug builds #12292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
de960ff
to
563ab1e
Compare
@@ -394,6 +394,29 @@ jobs: | |||
path: artifacts/TestResults/ | |||
publishOnError: true | |||
|
|||
- template: jobs/default-build.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will run in every build, PR or not. Suggest creating a build matrix in the Test Windows Server 2016 x64 job and make the Debug side of it conditional on it not being a PR build, then use $(_BuildConfig)
instead of Release
where necessary.
Overall, this is kind of the opposite of what we do in https://github.com/aspnet/Extensions. Extensions code of interest is https://github.com/aspnet/Extensions/blob/8385543edac69a2b817756d1ba81a63acf76518d/azure-pipelines.yml#L78-L88.
In particular, I'm suggesting
strategy:
matrix:
${{ if notin(variables['Build.Reason'], 'PullRequest') }}:
Debug:
_BuildConfig: Debug
Release:
_BuildConfig: Release
Could also only do the Debug side of the matrix in (say) internal builds. Up to you.
And, could add a schedule for this pipeline (avoiding something totally separate) and use in(variables['Build.Reason'], 'PullRequest')
as the condition above to only build Debug daily (for example).
Just make sure you update the title when you're ready so I'm not sending Tactics a tell-mode email for a PR titled "Let's see if..." 😛 |
Noted. If I thought about it more, I would have made this a draft. I could close and reopen as a draft if you want. |
Nah, it only matters if/when you merge it ;P |
07521f9
to
58cd02d
Compare
58cd02d
to
f3cff72
Compare
Closing as this is stale now. We can retarget to |
Hopefully this eventually addresses #11632