Skip to content

Blazor API Review: Microsoft.AspNetCore.Components.Web #12339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2019
Merged

Blazor API Review: Microsoft.AspNetCore.Components.Web #12339

merged 4 commits into from
Jul 21, 2019

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Jul 19, 2019

See: #12329

@rynowak rynowak force-pushed the rynowak/web-api-review branch from 2757bcb to 0677885 Compare July 19, 2019 03:34
@rynowak
Copy link
Member Author

rynowak commented Jul 19, 2019 •
edited
Loading

@SteveSandersonMS @pranavkm this is ready for review.

There's an issue that I need to investigate still - for some reason moving the EventHandlers and BindAttributes types to another assembly has broken colorization! Everything works fine except in the editor. I don't expect it to change the shape of what's in this PR too much but I want to investigate before moving forward.

I can't reproduce the problem with newer VS bits than the public preview.

I think the issue is that we look for BindMethods in the public preview tooling and it's no longer there.

@rynowak rynowak requested a review from a team as a code owner July 19, 2019 03:55
pranavkm
pranavkm approved these changes Jul 19, 2019
View reviewed changes
@Eilon Eilon added the area-blazor Includes: Blazor, Razor Components label Jul 19, 2019
@rynowak
Copy link
Member Author

rynowak commented Jul 19, 2019

@SteveSandersonMS

@rynowak rynowak force-pushed the rynowak/web-api-review branch 2 times, most recently from dd733b2 to 4c29eb0 Compare July 20, 2019 00:17
@SteveSandersonMS SteveSandersonMS self-requested a review July 20, 2019 13:57
SteveSandersonMS
SteveSandersonMS approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's excellent to see it's possible to move all this stuff out into .Web. It feels like the "core" vs "web" layering is actually making sense now.

Without blocking this PR, let's also discuss whether we want to API-review all the eventargs types and strip them down to the set that actually makes sense in Blazor today. Quite a number of them can't be used for anything practical, as per my comments here.

@rynowak rynowak force-pushed the rynowak/web-api-review branch from 4c29eb0 to 1fe7c76 Compare July 20, 2019 17:45
rynowak and others added 4 commits July 21, 2019 12:37
@rynowak
Move Forms to Web
e0541e9
@rynowak
Move NavLink to Web
9953aa1 
Also undid the use of ref assemblies in our tests. This is kinda wierd
and breaks dev inner-loop.
@rynowak
Move UIEventArgs types
4588840
Update refs
3c4dd4c
@rynowak rynowak force-pushed the rynowak/web-api-review branch from 1fe7c76 to 3c4dd4c Compare July 21, 2019 19:37
@rynowak rynowak merged commit 6421c41 into master Jul 21, 2019
@ghost ghost deleted the rynowak/web-api-review branch July 21, 2019 21:28
@mkArtakMSFT mkArtakMSFT added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

@pranavkm pranavkm pranavkm approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rynowak @pranavkm @SteveSandersonMS @Eilon @mkArtakMSFT