Blazor API Review: Server-side startup code #12371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
commented
Jul 19, 2019
| @@ -26,7 +26,7 @@ public class CircuitOptions | |||
| /// <value> | |||
| /// Defaults to <c>100</c>. | |||
| /// </value> | |||
| public int MaxRetainedDisconnectedCircuits { get; set; } = 100; | |||
| public int DisconnectedCircuitMaxRetained { get; set; } = 100; | |||
There was a problem hiding this comment.
Renamed to be consistent with DisconnectedCircuitRetentionPeriod
pranavkm
approved these changes
Jul 19, 2019
Fixes: #12220 Just some small tweaks here, it's already great.
rynowak
force-pushed
the
rynowak/server-side-startup
branch
from
9cf79f3 to
d62af1a
Compare
ghost
deleted the
mkArtakMSFT
added
the
tell-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12220
Just some small tweaks here, it's already great.