Skip to content

Blazor API Review: RenderTreeBuilder #12460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2019
Merged

Blazor API Review: RenderTreeBuilder #12460

merged 1 commit into from
Jul 25, 2019

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented Jul 23, 2019

Fixes: #12415

@rynowak rynowak requested a review from SteveSandersonMS July 23, 2019 03:52
@Eilon Eilon added the area-blazor Includes: Blazor, Razor Components label Jul 23, 2019
SteveSandersonMS
SteveSandersonMS approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Glad you spotted we could remove the constructor param too!

@rynowak rynowak force-pushed the rynowak/render-tree-builder branch from 4182b81 to 393e303 Compare July 24, 2019 15:25
@rynowak rynowak force-pushed the rynowak/render-tree-builder branch from 393e303 to 717f05a Compare July 24, 2019 17:14
@rynowak rynowak modified the milestone: 3.0.0-preview9 Jul 25, 2019
@rynowak rynowak merged commit 6526022 into master Jul 25, 2019
@ghost ghost deleted the rynowak/render-tree-builder branch July 25, 2019 16:45
@mkArtakMSFT mkArtakMSFT added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianwright109 adrianwright109 adrianwright109 left review comments

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blazor API Review: RenderTreeBuilder
5 participants
@rynowak @SteveSandersonMS @adrianwright109 @Eilon @mkArtakMSFT