Skip to content

Prevent invalid concurrent batches #12917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2019
Merged

Prevent invalid concurrent batches #12917

merged 1 commit into from
Aug 6, 2019

Conversation

SteveSandersonMS
Copy link
Member

This is needed since #12763

I meant to ensure we were doing it there, but forgot that when doing the final review.

@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label Aug 6, 2019
@SteveSandersonMS SteveSandersonMS added this to the 3.0.0-preview9 milestone Aug 6, 2019
@SteveSandersonMS SteveSandersonMS added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 6, 2019
javiercn
javiercn approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The EnsureSynchronizationContext() call already takes care of that so I didn't realize that you wanted an explicit check here. Sorry about that.

@SteveSandersonMS SteveSandersonMS merged commit 08349ab into release/3.0 Aug 6, 2019
@ghost ghost deleted the stevesa/prevent-invalid-concurrent-batches branch August 6, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

@javiercn javiercn javiercn approved these changes

@rynowak rynowak Awaiting requested review from rynowak

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
3.0.0-preview9
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveSandersonMS @pranavkm @javiercn