Add 'firstRender' parameter to OnAfterRender #13029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
force-pushed
the
rynowak/on-after-render
branch
from
73c42cb to
f0a4acf
Compare
rynowak
requested review from
analogrelay,
BrennanConroy,
halter73,
jkotalik,
mikaelm12,
Tratcher and
a team
as code owners
rynowak
removed request for
a team,
analogrelay,
halter73,
Tratcher,
mikaelm12,
BrennanConroy and
jkotalik
dougbu
reviewed
Aug 10, 2019
rynowak
force-pushed
the
rynowak/on-after-render
branch
2 times, most recently
from
f022583 to
9b71ecc
Compare
rynowak
commented
Aug 12, 2019
src/Components/Blazor/testassets/Microsoft.AspNetCore.Blazor.E2EPerformance/Pages/Index.razor
Outdated
Show resolved
Hide resolved
Fixes: #11610 I took the approach here of building this into `ComponentBase` instead of `IHandleAfterRender` - *because* my reasoning is that `firstTime` is an opinionated construct. There's nothing fundamental about `firstTime` that requires tracking by the rendering, it's simply an opinion that it's going to be useful for component authors, and reinforces a common technique. Feedback on this is welcome.
rynowak
force-pushed
the
rynowak/on-after-render
branch
from
9b71ecc to
2b3ceb1
Compare
|
@SteveSandersonMS - updated |
rynowak
added
API Review
tell-mode
pranavkm
changed the title
pranavkm
approved these changes
Aug 12, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11610
I took the approach here of building this into
ComponentBaseinsteadof
IHandleAfterRender- because my reasoning is thatfirstTimeisan opinionated construct. There's nothing fundamental about
firstTimethat requires tracking by the rendering, it's simply an opinion that
it's going to be useful for component authors, and reinforces a common
technique.