Update SignalR Sample #13078
Merged
Update SignalR Sample #13078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelm12
requested review from
analogrelay,
BrennanConroy and
halter73
as code owners
halter73
reviewed
Aug 13, 2019
| @@ -83,6 +84,13 @@ <h4>Group Actions</h4> | |||
| <script src="lib/signalr/signalr-protocol-msgpack.js"></script> | |||
| <script src="utils.js"></script> | |||
| <script> | |||
| var name = prompt("Please enter your name", "D'Artagnan"); | |||
There was a problem hiding this comment.
Can we just have a normal text input box with a default value of "Anonymous" or "D'Artagnan" or whatever for the user name? That way it doesn't block the entire browser UI.
There was a problem hiding this comment.
Agreed. We had the prompt in other places where we connected on page load. If we have a "Connect" gesture we can use a standard text box. I would also suggest having the "Connect" button check for a non-empty user name and produce an error (and not connect) in that case.
halter73
reviewed
Aug 13, 2019
| { | ||
| await Clients.Others.SendAsync("Send", $"{Context.ConnectionId} left"); |
There was a problem hiding this comment.
Can we include the user name in the query string or something so we can keep the user joined/left messages?
halter73
approved these changes
Aug 13, 2019
ghost
deleted the
mikaelm12
added
the
tell-mode
analogrelay
reviewed
Aug 13, 2019
| @@ -27,6 +27,7 @@ <h1 id="head1">SignalR Hubs Sample</h1> | |||
| <option value="hubT">Hub<T></option> | |||
| </select> | |||
|
|
|||
| <input type="text" id="displayname" placeholder="Enter User Name" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making our sample look nicer. This is more similar to what we have in the samples repo.