Skip to content

Fix issue/1312 - Use caching in docker build #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix issue/1312 - Use caching in docker build #1313

wants to merge 1 commit into from

Conversation

AlexChesser
Copy link

Per comment in issue #1312

the current state of the dockerfile in the aspnet/home repo does not use docker caching on DNU RESTORE (soon to be dotnet restore)

A small fix to the sample dockerfile can make the compile time of "second deploy" in docker 23x faster

old-speed for every deploy & first deploy under new method: ~3m30s
Start: 06:03:13.313
Finish: 06:06:40.640

new-speed - second & subsequent deploys if dependencies are unchanged: ~9s
Start: 06:00:36:036
Finish: 06:00:45:045

I also posted the FULL LOG of the difference over here: aspnet/aspnet-docker#123

@dnfclas
Copy link

dnfclas commented Feb 19, 2016

Hi @AlexChesser, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@glennc
Copy link
Contributor

glennc commented Mar 15, 2016

You can't do this unless the application you are deploying also has a .dockerignore file in order to avoid copying the lock file from the app into the image. Otherwise it will fail at runtime if you have restored on the host as well as in the image.

@Eilon
Copy link
Contributor

Eilon commented Nov 21, 2016

@glennc any thoughts on this?

@glennc
Copy link
Contributor

glennc commented Nov 21, 2016

No longer relevant now that there are no samples here.

@glennc glennc closed this Nov 21, 2016
natemcmaster pushed a commit that referenced this pull request Dec 1, 2018
JunTaoLuo pushed a commit that referenced this pull request May 7, 2020
Go to definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants