Remove IComponentContext #13132
Merged
Remove IComponentContext #13132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes part of: #12553 We don't believe that this is needed anymore. We no longer call OnAfterRender when you're prerendering, so the main use case of this type is gone.
rynowak
added
area-blazor
pranavkm
approved these changes
Aug 14, 2019
ghost
deleted the
|
Do you have any advice on how services that relied on IComponentContext to know the connection was complete can now test for that? It seems like the only choices now will be to require a component to "inform" the service(s) that we are connected or to wrap anything that may fail if called too early in the lifecycle in a loop and a try..catch, neither of which are great solutions for testing connectivity. Thanks |
|
I've had some discussions about this already here - #13296 Could you comment there are give me a little more concrete info about your scenarios? My guess is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of: #12553
We don't believe that this is needed anymore. We no longer call
OnAfterRender when you're prerendering, so the main use case of this
type is gone.
The recommendation is to use
OnAfterRenderand track the state yourself if you want to know whether you're in prerendering or not.