Skip to content

Fix Angular SPA Template compiler bug #13485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Fix Angular SPA Template compiler bug #13485

merged 1 commit into from
Sep 11, 2019

Conversation

speige
Copy link
Contributor

@speige speige commented Aug 27, 2019

Summary of the changes (Less than 80 chars)

  • Make StreamReader send last line's contents to listener (otherwise AngularCliBuilder doesn't know when build:ssr is complete)

Addresses #6306

… otherwise AngularCliBuilder doesn't know when build:ssr is complete
@mkArtakMSFT mkArtakMSFT added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 28, 2019
@mkArtakMSFT
Copy link
Contributor

Thanks for your effort, @speige .
@SteveSandersonMS , @ryanbrandenburg can you guys please review this? Thanks.

Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use case you reported it for (ssr) is no longer supported, but I think this is still a good fix.

@ryanbrandenburg
Copy link
Contributor

I have to retry the build because of a flaky test, will check back once that's done.

@mkArtakMSFT mkArtakMSFT merged commit 71c5c66 into dotnet:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants