Prevent null refs in RemoteJSRuntime #14603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
commented
Oct 1, 2019
| @@ -70,12 +70,12 @@ private void EndInvokeDotNetCore(string callId, bool success, object resultOrErr | |||
|
|
|||
| protected override void BeginInvokeJS(long asyncHandle, string identifier, string argsJson) | |||
| { | |||
| if (!_clientProxy.Connected) | |||
| if (_clientProxy is null) | |||
There was a problem hiding this comment.
_clientProxy isn't initiailized during pre-rendering and this change reflects that. Knowing how unreliable the the Connected flag is, it made sense to avoid checking it here. It makes the experience with JSInterop a bit more consistent - users should now consistently see timeouts from JSInterop calls when the client send failed, rather than a timeout sometime and a sync exception at other times.
SteveSandersonMS
approved these changes
Oct 1, 2019
pranavkm
force-pushed
the
prkrishn/null-ref
branch
from
29ef10d to
384e39e
Compare
pranavkm
force-pushed
the
prkrishn/null-ref
branch
from
384e39e to
3f24f52
Compare
|
@pranavkm can you elaborate on the type of exception we can expect to see from the jsruntime in the various fail/error conditions, e.g. during timeouts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13396