Skip to content

updating inline <code> to <c> #17611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2019
Merged

updating inline <code> to <c> #17611

merged 5 commits into from
Dec 11, 2019

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Dec 5, 2019

@eddynaka eddynaka changed the title updating inline "code" tag to "c" tag updating inline <code> to <c> Dec 5, 2019
analogrelay
analogrelay suggested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@analogrelay analogrelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. A few more usages of <see langword> are needed. Also some HTML content in the product got changed by your scan.

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Dec 5, 2019
analogrelay
analogrelay approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@analogrelay analogrelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to get a clean build (it's likely any failures are unrelated to this change, as long as the XML is valid, I'll keep an eye on it).

@eddynaka
Copy link
Contributor Author

eddynaka commented Dec 5, 2019

Nice! thanks!

@mkArtakMSFT mkArtakMSFT added this to the 5.0.0-preview1 milestone Dec 11, 2019
@mkArtakMSFT
Copy link
Contributor

Thanks for your effort, @eddynaka.

@mkArtakMSFT mkArtakMSFT merged commit 5ff9ed6 into dotnet:master Dec 11, 2019
@eddynaka
Copy link
Contributor Author

Thanks for approving!

@eddynaka eddynaka deleted the updating-comments-code branch December 11, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@analogrelay analogrelay analogrelay approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@Tratcher Tratcher Awaiting requested review from Tratcher

@Rick-Anderson Rick-Anderson Awaiting requested review from Rick-Anderson

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@eddynaka @mkArtakMSFT @analogrelay @Pilchie