Skip to content

Update PoliCheckExclusions.xml #17705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Update PoliCheckExclusions.xml #17705

merged 1 commit into from
Jan 15, 2020

Conversation

BrennanConroy
Copy link
Member

Ignore test log output

Ignore test log output
@BrennanConroy BrennanConroy added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 9, 2019
@BrennanConroy BrennanConroy requested a review from a team as a code owner December 9, 2019 17:06
@BrennanConroy
Copy link
Member Author

FYI this is on the 3.1 branch since it looks like that's when we added the check.

@wtgodbe
Copy link
Member

wtgodbe commented Dec 9, 2019

@BrennanConroy please hold off on merging until we finish builds for 3.1.1. That likely means waiting until January. Feel free to manually put up a port PR in master if you want it there earlier

@BrennanConroy BrennanConroy changed the title Update PoliCheckExclusions.xml [Do Not Merge] Update PoliCheckExclusions.xml Dec 9, 2019
@BrennanConroy BrennanConroy added the blocked The work on this issue is blocked due to some dependency label Dec 9, 2019
@BrennanConroy
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@BrennanConroy
Copy link
Member Author

@dotnet/aspnet-build can we merge this now?

@dougbu
Copy link
Contributor

dougbu commented Jan 14, 2020

@BrennanConroy no.

The branding updates, #18151 in particular for this base branch, must go in first. @JunTaoLuo needs to update these PRs and wait for validation to completely. He's working his way through the repos.

@BrennanConroy BrennanConroy changed the title [Do Not Merge] Update PoliCheckExclusions.xml Update PoliCheckExclusions.xml Jan 15, 2020
@BrennanConroy BrennanConroy removed the blocked The work on this issue is blocked due to some dependency label Jan 15, 2020
@BrennanConroy
Copy link
Member Author

@dotnet/aspnet-build please merge! 😸

@analogrelay analogrelay added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 15, 2020
@analogrelay analogrelay merged commit cf3bf40 into release/3.1 Jan 15, 2020
@analogrelay analogrelay deleted the brecon/exclude branch January 15, 2020 22:34
dougbu added a commit that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants