Skip to content

Add dummy target for GetTargetPath to Components.Web.JS.npmproj #17796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Dec 11, 2019

This target can't be found while packing packages for template tests on OSX (see https://dev.azure.com/dnceng/internal/_build/results?buildId=454267&view=logs&j=f43b187f-6c15-531c-a59b-e4fba4e9ed20&t=0320c262-df6f-5d53-a73e-eb9e8f5ce7e4). This is a workaround to unblock 3.0.2 while we investigate the root cause

@dougbu
Copy link
Contributor

dougbu commented Dec 11, 2019

If the problem only happens on some platforms, figuring out the root cause may require downloading a large binary log. Sorry @wtgodbe ☹️

@wtgodbe
Copy link
Member Author

wtgodbe commented Dec 11, 2019

#17798

@Pilchie
Copy link
Member

Pilchie commented Dec 11, 2019

@rainersigwald is this the right approach? Would using <ReferenceOutputAssembly>false</ReferenceOutputAssembly> solve this instead?

@dougbu
Copy link
Contributor

dougbu commented Dec 12, 2019

@Pilchie and @rainersigwald FYI @wtgodbe filed #17798 about the root cause of the new errors we're getting since we got #17311 in. Doing it all i.e. getting to the best fix in this PR sounds great to me 😺

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 12, 2019
@wtgodbe wtgodbe merged commit 3c2bc51 into release/3.0 Dec 13, 2019
@wtgodbe wtgodbe deleted the npm branch December 13, 2019 21:38
wtgodbe added a commit to dotnet-maestro-bot/AspNetCore that referenced this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants