[release/3.1] Update dependencies from dotnet/efcore dotnet/aspnetcore-tooling #18363

dotnet-maestro · 2020-01-15T20:27:05Z

This pull request updates the following dependencies

From https://github.com/dotnet/efcore

Subscription: 94910a9f-24ae-4376-fb11-08d794a352c5
Build: 20200114.5
Date Produced: 1/15/2020 1:21 AM
Commit: 6cf5ee68c68e0d8eaaa929e04bfbfaf97314791a
Branch: refs/heads/release/3.1
Updates:
- Microsoft.EntityFrameworkCore.Tools -> 3.1.2
- Microsoft.EntityFrameworkCore.SqlServer -> 3.1.2
- dotnet-ef -> 3.1.2
- Microsoft.EntityFrameworkCore -> 3.1.2
- Microsoft.EntityFrameworkCore.InMemory -> 3.1.2
- Microsoft.EntityFrameworkCore.Relational -> 3.1.2
- Microsoft.EntityFrameworkCore.Sqlite -> 3.1.2

From https://github.com/dotnet/aspnetcore-tooling

Subscription: 5eda9ad6-6b49-4d8c-ace3-08d7842ce357
Build: 20200115.8
Date Produced: 1/16/2020 12:29 AM
Commit: 18bfc128c07023e9384697fba876df575238dba9
Branch: refs/heads/release/3.1
Updates:
- Microsoft.AspNetCore.Mvc.Razor.Extensions -> 3.1.2
- Microsoft.AspNetCore.Razor.Language -> 3.1.2
- Microsoft.CodeAnalysis.Razor -> 3.1.2
- Microsoft.NET.Sdk.Razor -> 3.1.2

…114.5 - Microsoft.EntityFrameworkCore.Tools - 3.1.2 - Microsoft.EntityFrameworkCore.SqlServer - 3.1.2 - dotnet-ef - 3.1.2 - Microsoft.EntityFrameworkCore - 3.1.2 - Microsoft.EntityFrameworkCore.InMemory - 3.1.2 - Microsoft.EntityFrameworkCore.Relational - 3.1.2 - Microsoft.EntityFrameworkCore.Sqlite - 3.1.2

dotnet-maestro · 2020-01-15T20:27:07Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…build 20200114.7 - Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.1.2 - Microsoft.AspNetCore.Razor.Language - 3.1.2 - Microsoft.CodeAnalysis.Razor - 3.1.2 - Microsoft.NET.Sdk.Razor - 3.1.2

wtgodbe · 2020-01-15T23:58:22Z

Template test failures look real:

Project new reactredux failed to publish.\r\nProcess exited with code 1\nStdErr: \nStdOut: Microsoft (R) Build Engine version 16.4.0+e901037fe for .NET Core\r\nCopyright (C) Microsoft Corporation. All rights reserved.\r\n\r\nF:\workspace_work\1\s.dotnet\sdk\3.1.100\MSBuild.dll -maxcpucount -property:Configuration=Release -restore -target:Publish -verbosity:m /bl .\AspNet.reactredux.ehc2paudsjd.csproj\r\n Restore completed in 58.4 ms for F:\workspace_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.reactredux.ehc2paudsjd\AspNet.reactredux.ehc2paudsjd.csproj.\r\nobj\Release\netcoreapp3.1\AspNet.reactredux.ehc2paudsjd.MvcApplicationPartsAssemblyInfo.cs(13,33): error CS0234: The type or namespace name 'Mvc' does not exist in the namespace 'Microsoft.AspNetCore' (are you missing an assembly reference?) [F:\workspace_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.reactredux.ehc2paudsjd\AspNet.reactredux.ehc2paudsjd.csproj]\r\nobj\Release\netcoreapp3.1\AspNet.reactredux.ehc2paudsjd.MvcApplicationPartsAssemblyInfo.cs(14,33): error CS0234: The type or namespace name 'Mvc' does not exist in the namespace 'Microsoft.AspNetCore' (are you missing an assembly reference?) [F:\workspace_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.reactredux.ehc2paudsjd\AspNet.reactredux.ehc2paudsjd.csproj]\r\nobj\Release\netcoreapp3.1\AspNet.reactredux.ehc2paudsjd.RazorAssemblyInfo.cs(13,33): error CS0234: The type or namespace name 'Mvc' does not exist in the namespace 'Microsoft.AspNetCore' (are you missing an assembly reference?)

@dougbu could you take a look?

dotnet-maestro · 2020-01-15T23:58:48Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-01-16T00:40:02Z

@wtgodbe that problem isn't specific to this branch. suggest working backward through the rolling or official builds to see when it was introduced (today).

dotnet-maestro · 2020-01-16T00:44:11Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

wtgodbe · 2020-01-16T00:45:33Z

First place I'm seeing it is in the internal build for #18357, but that PR had the template tests pass. Will take a closer look

dotnet-maestro · 2020-01-16T00:49:14Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

wtgodbe · 2020-01-16T00:49:39Z

Also CC @JunTaoLuo in case anything stands out

dotnet-maestro · 2020-01-16T00:54:17Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Linux Source Build), aspnetcore-ci (Build Test: macOS 10.13), aspnetcore-ci (Build Test: Ubuntu 16.04 x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Build: Linux Musl x64), aspnetcore-ci (Build Build: Linux Musl ARM64), aspnetcore-ci (Build Build: Linux ARM64), aspnetcore-ci (Build Build: Linux ARM), aspnetcore-ci (Build Build: Linux x64), aspnetcore-ci (Build Build: macOS), aspnetcore-ci (Build Build: Windows ARM), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Code check)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…build 20200115.8 - Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.1.2 - Microsoft.AspNetCore.Razor.Language - 3.1.2 - Microsoft.CodeAnalysis.Razor - 3.1.2 - Microsoft.NET.Sdk.Razor - 3.1.2

NuGet.config

dougbu · 2020-01-16T01:30:08Z

@wtgodbe check the final commit that went in for #18357. The merge might have messed something up.

Note this problem affects PR validation as well. See for example the first round of validation for #17581

dotnet-maestro · 2020-01-16T01:34:36Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Linux Source Build), aspnetcore-ci (Build Test: macOS 10.13), aspnetcore-ci (Build Test: Ubuntu 16.04 x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Build: Linux Musl x64), aspnetcore-ci (Build Build: Linux Musl ARM64), aspnetcore-ci (Build Build: Linux ARM64), aspnetcore-ci (Build Build: Linux ARM), aspnetcore-ci (Build Build: Linux x64), aspnetcore-ci (Build Build: macOS), aspnetcore-ci (Build Build: Windows ARM), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Code check)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-01-16T01:39:43Z

Suspect the templates problem is not specifically coming from #18357. If the previous official or rolling build succeeded, need to check all the commits merged between them (we don't run multiple builds of any branch in parallel).

dotnet-maestro · 2020-01-16T01:44:42Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Linux Source Build), aspnetcore-ci (Build Test: macOS 10.13), aspnetcore-ci (Build Test: Ubuntu 16.04 x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Build: Linux Musl x64), aspnetcore-ci (Build Build: Linux Musl ARM64), aspnetcore-ci (Build Build: Linux ARM64), aspnetcore-ci (Build Build: Linux ARM), aspnetcore-ci (Build Build: Linux x64), aspnetcore-ci (Build Build: macOS), aspnetcore-ci (Build Build: Windows ARM), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Code check)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-01-16T02:22:41Z

Building all of the commits between the failing and successful official builds in #18371 ("dougbu/head-3") through #18379 ("dougbu/head-B"). Last one matches the successful build to eliminate an unexpected change in the agents or something we download the latest of.

dotnet-maestro · 2020-01-16T02:25:02Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

JunTaoLuo · 2020-01-16T08:00:38Z

I may have cracked the enigma, see #18380

dotnet-maestro · 2020-01-16T08:02:54Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

Pilchie · 2020-01-16T16:48:46Z

👀

dotnet-maestro · 2020-01-16T16:52:52Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-01-16T16:54:22Z

/azp run aspnetcore-ci

azure-pipelines · 2020-01-16T16:54:33Z

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-maestro · 2020-01-16T16:57:55Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci (Build Test: Ubuntu 16.04 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-01-16T17:36:35Z

@JunTaoLuo many thanks -- you did indeed crack the enigma❕

FYI the problem was introduced in ee57a0c "Use checked-in platform manifest in 3.1.2 (#18250)" though it's not clear how that caused the test regressions. But, it's pretty clear because #18379 aka dougbu/head-B -- which went back all the way to 36e7902 "Merge pull request #18151 from dotnet/johluo/feb-branding", the last successful official build's commit -- was the only test build that avoided the many template test failures.

dotnet-maestro · 2020-01-16T17:38:24Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci (Build Test: Ubuntu 16.04 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

JunTaoLuo · 2020-01-16T18:23:05Z

I don't think ee57a0c was the issue. It failed the build since it turned ref pack generation on. The underlying problem with how assemblies were resolved must have been silently introduced earlier.

dotnet-maestro · 2020-01-16T18:23:50Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: aspnetcore-ci, aspnetcore-ci (Build Test: Ubuntu 16.04 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-01-16T18:48:34Z

@JunTaoLuo your statement is slightly contradictory. That commit introduced the problem because it turned targeting and ref/ pack builds back on. But, I agree the root cause was deeper.

dotnet-maestro · 2020-01-16T18:49:05Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: aspnetcore-ci, aspnetcore-ci (Build Test: Ubuntu 16.04 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dotnet-maestro bot requested a review from dougbu as a code owner January 15, 2020 20:27

Update dependencies from https://github.com/dotnet/aspnetcore-tooling …

50cb0a4

…build 20200114.7 - Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.1.2 - Microsoft.AspNetCore.Razor.Language - 3.1.2 - Microsoft.CodeAnalysis.Razor - 3.1.2 - Microsoft.NET.Sdk.Razor - 3.1.2

dotnet-maestro bot changed the title ~~[release/3.1] Update dependencies from dotnet/efcore~~ [release/3.1] Update dependencies from dotnet/efcore dotnet/aspnetcore-tooling Jan 15, 2020

wtgodbe added 2 commits January 15, 2020 13:53

Fixup nuget.config

c41ef94

fixup nuget.config

a071657

Update dependencies from https://github.com/dotnet/aspnetcore-tooling …

15f47ec

…build 20200115.8 - Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.1.2 - Microsoft.AspNetCore.Razor.Language - 3.1.2 - Microsoft.CodeAnalysis.Razor - 3.1.2 - Microsoft.NET.Sdk.Razor - 3.1.2

JunTaoLuo reviewed Jan 16, 2020

View reviewed changes

NuGet.config Outdated Show resolved Hide resolved

Remove internal sources

f1e4242

wtgodbe merged commit 405e841 into release/3.1 Jan 16, 2020

wtgodbe deleted the darc-release/3.1-4b1815ab-56f3-4565-b69f-efb55319e60d branch January 16, 2020 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/3.1] Update dependencies from dotnet/efcore dotnet/aspnetcore-tooling #18363

[release/3.1] Update dependencies from dotnet/efcore dotnet/aspnetcore-tooling #18363

dotnet-maestro bot commented Jan 15, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 15, 2020 •

edited

Loading

wtgodbe commented Jan 15, 2020

dotnet-maestro bot commented Jan 15, 2020 •

edited

Loading

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020

wtgodbe commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020

wtgodbe commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dougbu commented Jan 16, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

JunTaoLuo commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

Pilchie commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020

dougbu commented Jan 16, 2020

azure-pipelines bot commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

JunTaoLuo commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

[release/3.1] Update dependencies from dotnet/efcore dotnet/aspnetcore-tooling #18363

[release/3.1] Update dependencies from dotnet/efcore dotnet/aspnetcore-tooling #18363

Conversation

dotnet-maestro bot commented Jan 15, 2020 • edited Loading

From https://github.com/dotnet/efcore

From https://github.com/dotnet/aspnetcore-tooling

dotnet-maestro bot commented Jan 15, 2020 • edited Loading

Auto-Merge Status

wtgodbe commented Jan 15, 2020

dotnet-maestro bot commented Jan 15, 2020 • edited Loading

Auto-Merge Status

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020

Auto-Merge Status

wtgodbe commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020

Auto-Merge Status

wtgodbe commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 • edited Loading

Auto-Merge Status

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 • edited Loading

Auto-Merge Status

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 • edited Loading

Auto-Merge Status

dougbu commented Jan 16, 2020 • edited Loading

dotnet-maestro bot commented Jan 16, 2020 • edited Loading

Auto-Merge Status

JunTaoLuo commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 • edited Loading

Auto-Merge Status

Pilchie commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020

Auto-Merge Status

dougbu commented Jan 16, 2020

azure-pipelines bot commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 • edited Loading

Auto-Merge Status

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 • edited Loading

Auto-Merge Status

JunTaoLuo commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 • edited Loading

Auto-Merge Status

dougbu commented Jan 16, 2020

dotnet-maestro bot commented Jan 16, 2020 • edited Loading

Auto-Merge Status

dotnet-maestro bot commented Jan 15, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 15, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 15, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dougbu commented Jan 16, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading

dotnet-maestro bot commented Jan 16, 2020 •

edited

Loading