Add missing assemblies to ref pack

[JunTaoLuo]

This fixes the incorrect condition from #18380. The issue is that the CoreFx ref assemblies do not have the IsAssemblyReference metadata set. As a result, the assemblies were excluded from the AspNetCore.App.Ref ref pack.

This PR updates the condition so that only the assemblies with IsAssemblyReference set to false are excluded.

[dougbu]

Have trouble believing the previous Exclude item was wrong. Instead the ref/ project shouldn't provide metadata in @(ReferencePathWithRefAssemblies).

[JunTaoLuo]

Ahh, I think I now understand what you mean. We should probably investigate what's happening here.

[dougbu]

I believe we need to exclude %(IsReferenceAssemblyProject) items from @(AspNetCoreAppReference) in the main @(Reference) item group at

aspnetcore/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj

Line 62 in 0e4635c

<Reference Include="@(AspNetCoreAppReference);@(AspNetCoreAppReferenceAndPackage);@(ExternalAspNetCoreAppReference)" />

then add another with <ReferenceOutputAssembly>false</ReferenceOutputAssembly> for the @(AspNetCoreAppReference) items that are from ref/ projects. Might be possible to shorten the new code to

<ItemGroup>
  <Reference Include="@(AspNetCoreAppReference);@(AspNetCoreAppReferenceAndPackage);@(ExternalAspNetCoreAppReference)">
    <ReferenceOutputAssembly Condition=" '%(IsReferenceAssemblyProject)' == 'true' ">false</ReferenceOutputAssembly>
  </Reference>

[dougbu]

Might be fine to remove references to the ref/ projects entirely i.e. exclude @(AspNetCoreAppReference) and @(AspNetCoreAppReferenceAndPackage) items with '%(IsReferenceAssemblyProject)' == 'true' metadata. Of course, need to confirm that metadata is present. (Root cause here is those two item groups map names to projects and the names are ambiguous.)

[JunTaoLuo]

Spot checking and it seems like the CoreFx binaries are now included in the ref pack:

[wtgodbe]

This has the same content as the 3.1.0 ref pack now (the same 253 items). However, we now need to make sure that the updated ref assembly from System.IO.Pipelines 4.7.1 does not make it in to the 3.1.3 targeting pack, but we do need to include the patched implementation assembly in the runtime pack (see dotnet/corefx#42837). @dougbu @JunTaoLuo @ericstj any ideas?

[wtgodbe]

Convert

aspnetcore/eng/SharedFramework.External.props

Lines 55 to 72 in ff6e1eb

	<ExternalAspNetCoreAppReference Include="System.IO.Pipelines" Version="$(SystemIOPipelinesPackageVersion)" />
	<ExternalAspNetCoreAppReference Include="System.Security.Cryptography.Xml" Version="$(SystemSecurityCryptographyXmlPackageVersion)" />
	<!--
	Transitive dependencies of other assemblies in the shared framework. These are listed separately and should not be included directly
	when setting `<Reference>`. These are listed for the purpose of tests and servicing builds only.
	If implementation details change and these assemblies are no longer showing up in the shared framework as a result of that,
	it is okay to remove these transitive dependencies.
	If these are needed as direct dependencies, it is okay to change them to ExternalAspNetCoreAppReference and move up into sections above.
	-->
	<_TransitiveExternalAspNetCoreAppReference Include="Microsoft.Win32.SystemEvents" Version="$(MicrosoftWin32SystemEventsPackageVersion)" />
	<_TransitiveExternalAspNetCoreAppReference Include="System.Diagnostics.EventLog" Version="$(SystemDiagnosticsEventLogPackageVersion)" />
	<_TransitiveExternalAspNetCoreAppReference Include="System.Drawing.Common" Version="$(SystemDrawingCommonPackageVersion)" />
	<_TransitiveExternalAspNetCoreAppReference Include="System.Security.Cryptography.Pkcs" Version="$(SystemSecurityCryptographyPkcsPackageVersion)" />
	<_TransitiveExternalAspNetCoreAppReference Include="System.Security.Permissions" Version="$(SystemSecurityPermissionsPackageVersion)" />
	<_TransitiveExternalAspNetCoreAppReference Include="System.Windows.Extensions" Version="$(SystemWindowsExtensionsPackageVersion)" />

into 2 separate item groups, one for the latest versions and one for the PatchVersion=0 versions, which are used by the runtime pack & targeting pack respectively?

[JunTaoLuo]

@wtgodbe can you try that approach and see what it looks like? Feel free to update this branch.

[wtgodbe]

Took a crack at it with 903ddbd & cac1ed2. We'll need to wait until dotnet/corefx#42837 flows to AspNetCore to really be sure it worked.

[JunTaoLuo]

looks like tests are passing, @wtgodbe can you check the targeting pack?

[wtgodbe]

@JunTaoLuo I'll check it once we take the CoreFx change that bumps System.IO.Pipelines to 4.7.1 (which should be very soon)

[dougbu]

Other than @wtgodbe's extra newline (a nit 😈), code looks good. Of course, we want to be sure that part of the change works w/ new CoreFx packages before actual merge

[dougbu]

Thanks @JunTaoLuo for banging this out and @wtgodbe for your additions as well as

I'll check it once we take the CoreFx change

[wtgodbe]

Might not be able to validate this w/ the corefx change tonight, Maestro seems to be on the fritz - it hasn't opened any PRs in the last ~3 hours (@chcosta @riarenas @JohnTortugo @mmitche is it a known thing?)

[wtgodbe]

This is now ready to be validated once we have the build

[wtgodbe]

/__w/1/s/src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj : error NU1605: Detected package downgrade: System.IO.Pipelines from 4.7.1 to 4.7.0. Reference the package directly from the project to select a different version. [/__t/dotnet/sdk/3.1.100/NuGet.targets]

I'll add NU1605 to the ref pack's NoWarn, but will we wind up transitively bringing in the higher version anyway? CC @dougbu @JunTaoLuo

[wtgodbe]

##[error]eng/SharedFramework.External.props(10,18): error MSB4100: Expected "$(IsReferenceAssemblyProject)" to evaluate to a boolean instead of "", in condition "'$(MSBuildProjectName)' == 'Microsoft.AspNetCore.App.Ref' OR $(IsReferenceAssemblyProject) ".

Looks like IsReferenceAssemblyProject isn't always set. Will update the condition

[JunTaoLuo]

Which projects was resolving IsReferenceAssemblyProject as empty?

[wtgodbe]

Which projects was resolving IsReferenceAssemblyProject as empty?

I'm not sure, the build for Doug's commit seems to have disappeared

[wtgodbe]

The ref pack & runtime pack both look good! The ref pack has the same content as the 3.1.0, the same platform manifest as 3.1.2, and the 4.0.2.0 ref assembly for System.IO.Pipelines (rather than the newly versioned 4.0.2.1 version, which is in the 4.7.1 package we just ingested). The runtime pack has the same content as 3.1.2, and System.IO.Pipelines is versioned 4.0.2.1.

@dougbu @JunTaoLuo @ericstj anything else you'd like me to check on before merging?

[JunTaoLuo]

[dougbu]

Oh wait, who owns this now? I nominate @JunTaoLuo to do the final squash