Skip to content

Support int in InputSelect.cs #19562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support int in InputSelect.cs #19562

wants to merge 1 commit into from

Conversation

Julien-Marpault
Copy link

Add support to int type for inputSelect

@Julien-Marpault
Support int in InputSelect.cs
0088c35 
Add support to int type for inputSelect
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Mar 4, 2020
@mkArtakMSFT
Copy link
Contributor

Thanks for your PR, @JulienM28.
Looks like there are some build breaks as well as this change is missing some tests. We will need all that to move forward with this PR.

@mkArtakMSFT
Copy link
Contributor

@SteveSandersonMS can you please review this when the PR is updated with all the necessary bits? Thanks!

@Julien-Marpault
Copy link
Author

Ok, I'm not familiar wit hthe process it's my first.

I Will correct it soon.

Thanks.

@mkArtakMSFT
Copy link
Contributor

Thanks for your PR.
We're currently busy wrapping up our upcoming Blazor WASM release, which is planned to go out in May. That forces us to delay some community PR reviews which target ASP.NET Core 5.0, so please expect some delays here. We will get to this as soon as we wrap up the Blazor work.

@MackinnonBuck MackinnonBuck mentioned this pull request Jul 2, 2020
Merged
@MackinnonBuck
Copy link
Member

Thank you for your submission. This has been solved by #23415.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees

@MackinnonBuck MackinnonBuck

Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Julien-Marpault @mkArtakMSFT @MackinnonBuck @SteveSandersonMS