Skip to content

Fix #2442 by adding webmanifest extension to content-type map #19661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

analogrelay
Copy link
Contributor

Fixes #2442

We're very conservative about what we add to this list, restricting it only to high-value items that are backed by a clear RFC, well-adopted spec or IANA registration. WebManifest had a spec but now is getting enough hits (as PWAs become more common) and Blazor seems to be interfering with adding this manually (though I'm not sure I understand that and I think it needs further investigation).

@analogrelay analogrelay added this to the 5.0.0-preview3 milestone Mar 6, 2020
@analogrelay analogrelay requested a review from Tratcher as a code owner March 6, 2020 22:59
@ghost ghost added the area-middleware label Mar 6, 2020
@analogrelay
Copy link
Contributor Author

Chrome Network Tools showing a request to download a ".webmanifest" file from an ASP.NET Core application. The "Content-Type" header is highlighted and has the value "application/manifest+json".

There's no automated tests specifically for the mappings.

@ghost

This comment has been minimized.

@analogrelay analogrelay merged commit 8ec3159 into master Mar 10, 2020
@analogrelay analogrelay deleted the anurse/2442-webmanifest-content-type-mapping branch March 10, 2020 00:30
@madskristensen
Copy link
Contributor

Thanks @anurse

Just ran in to this again in ASP.NET Core 3.1 in a new app where it still is an issue. Glad to see it finally fixed.

@rpardini
Copy link

Just run into this, ASP.NET Core 3.1 and app.UseSpa()
Requests for /manifest.webmanifest return the spa.Options.DefaultPage instead due to missing mime map.
Then I realized @anurse's fix is only in 5.x....

@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for .webmanifest file extension
5 participants