Use custom DebugProxyHost to initialize DebugProxy config #19980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
SteveSandersonMS
approved these changes
Mar 19, 2020
|
Oh BTW if you're merging this today, I think it should go into the |
pranavkm
approved these changes
Mar 19, 2020
src/Components/WebAssembly/DebugProxy/src/Hosting/DebugProxyHost.cs
Outdated
Show resolved
Hide resolved
mkArtakMSFT
added
the
feature-blazor-wasm
ghost
pushed a commit
that referenced
this pull request
Mar 25, 2020
* Restore public API contract on WebAssemblyJSRuntime (#19968) * Shrink icon-512.png (#19999) * Use custom DebugProxyHost to initialize DebugProxy config (#19980) Addresses #19909 * Spruce up WebAssemblyHostEnvironment interface and use (#20008) * Load .dlls/.wasm/.pdb in parallel with dotnet.*.js. Fixes #18898 (#20029) * Add BaseAddress property to WebAssemblyHostEnvironment (#20019) - Adds `BaseAddress` to `IWebAssemblyHostEnvironment` - Uses unmarshalled APIs to extract application host - Move NavigationManager initialization to startup code - Fix subdir mapping in ClientSideHostingTest Addresses #19910 Co-authored-by: Steve Sanderson <[email protected]> Co-authored-by: Safia Abdalla <[email protected]> Co-authored-by: Safia Abdalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new DebugProxyHost that is used to configure and initialize the debugging proxy.
I migrated some of the applicable configs from the WebHostBuilder and migrated our configs that were in Program.cs to this class.
Following @pranavkm I also added support for loading configurations from a JSON file should we need this in the future.
Addresses #19909