[Blazor] Auth improvements #20073
Closed
[Blazor] Auth improvements #20073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Components/WebAssembly/Authentication.Msal/src/Models/MsalProviderOptions.cs
Show resolved
Hide resolved
captainsafia
approved these changes
Mar 24, 2020
| /// <param name="services">The <see cref="IServiceCollection"/>.</param> | ||
| /// <param name="configure">The <see cref="Action{RemoteAuthenticationOptions{MsalProviderOptions}}"/> to configure the <see cref="RemoteAuthenticationOptions{MsalProviderOptions}"/>.</param> | ||
| /// <returns>The <see cref="IServiceCollection"/>.</returns> | ||
| public static IServiceCollection AddMsalAuthentication<TRemoteAuthenticationState>(this IServiceCollection services, Action<RemoteAuthenticationOptions<MsalProviderOptions>> configure) |
There was a problem hiding this comment.
It looks like the configure parameter isn't used. Am I missing something? Why don't we call it any more?
| } catch (e) { | ||
| reject(e); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Minor stylistic point but rather than manually creating a promise and having a try/catch, it could do:
this._initialized = (async () => {
const userManager = await this.createUserManager(settings);
AuthenticationService.instance = new OidcAuthorizeService(userManager);
})();| @@ -15,7 +15,14 @@ | |||
| <Found Context="routeData"> | |||
| <AuthorizeRouteView RouteData="@routeData" DefaultLayout="@typeof(MainLayout)"> | |||
| <NotAuthorized> | |||
| <RedirectToLogin /> | |||
| @if(!context.User.Identity.IsAuthenticated) | |||
There was a problem hiding this comment.
Suggested change
| @if(!context.User.Identity.IsAuthenticated) | |
| @if (!context.User.Identity.IsAuthenticated) |
|
Is there any chance we're a bit short on test coverage with some of this? It's unusual to be able to fix a wide range of issues without impacting or adding any tests. I'm particularly thinking about the DI parts here - there are a lot of different combinations of overloads. Do you think they would be amenable to unit testing, or can this only be seen at the E2E level? |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19966
Multiple fixes for small issues in the auth packages:
<<authority>>/.well-known/openid-configuration