Replace RunTests scripts with .NET app #20337
Conversation
BrennanConroy
added
the
area-infrastructure
| environmentVariables: environmentVariables); | ||
|
|
||
| await ProcessUtil.RunAsync($"{dotnetRoot}/dotnet", | ||
| $"tool install dotnet-ef --global --version {efVersion}", |
There was a problem hiding this comment.
We set the DOTNET_CLI_HOME environment variable so it isn't "global". But maybe I should move some more of that logic out of the scripts
| $"vstest {target} -lt", | ||
| environmentVariables: environmentVariables); | ||
|
|
||
| if (discoveryResult.StandardOutput.Contains("Exception thrown")) |
There was a problem hiding this comment.
I'm not familiar with the specifics of this
#8107
|
Looks like I've got all tests running correctly now. So just need to do cleanup. |
|
I was invited to review this but have no context. What are the aims of this PR? |
|
Just figured you might be interested.
Replacing our scripts with .NET code. We know how to write in .NET and it consolidates our logic to one place instead of multiple. |
|
Ship it |
The overall approach is not a big deal to me either way. I am concerned about requiring that Helix agents build the new RunTests project. That will likely slow down every run enough to matter cumulatively (we do lots 'o runs). Suggest building then including the results in the job payloads.
nit: Not sure how valid the first point is given everyone needs to be familiar w/ MSBuild and scripting to do ops-on-call work. But, I agree maintaining |
|
@BrennanConroy unless you've confirmed the time spent on Helix agents hasn't worsened, please file a follow-up issue to move the RunTests.csproj build into the main job. |
|
It takes a couple seconds to build... this is definitely not an area we need to care about to improve PR/rolling builds... |
|
Well I guess its probably a little cleaner just to build the runtests thing as part of the normal builds, and just include the dll into helix content and run that dll in the scripts, since that would let us write unit tests against RunTests too, which probably is a good thing since its gotten pretty complicated now :/ |
Removing all our scripting logic from .cmd and .sh files for running tests on Helix and normalizing it into .NET code.