Skip to content

Quarantine ServerAcceptsRequestWithheaderTotalSizeWithinLimit #21191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Apr 25, 2020
Merged

Quarantine ServerAcceptsRequestWithheaderTotalSizeWithinLimit #21191

1 commit merged into from
Apr 25, 2020

Conversation

ryanbrandenburg
Copy link
Contributor 

Assert.Equal() Failure
          ↓ (pos 0)
Expected: HTTP/1.1 200 OK\r\nDate: Fri, 18 Mar 7887 1···
Actual:   
          ↑ (pos 0)
------
   at Microsoft.AspNetCore.Testing.StreamBackedTestConnection.Receive(String[] lines) in /_/src/Servers/Kestrel/shared/test/StreamBackedTestConnection.cs:line 125
   at Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests.RequestHeaderLimitsTests.ServerAcceptsRequestWithHeaderTotalSizeWithinLimit(Int32 headerCount, Int32 extraLimit) in /_/src/Servers/Kestrel/test/InMemory.FunctionalTests/RequestHeaderLimitsTests.cs:line 35
   at Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests.RequestHeaderLimitsTests.ServerAcceptsRequestWithHeaderTotalSizeWithinLimit(Int32 headerCount, Int32 extraLimit) in /_/src/Servers/Kestrel/test/InMemory.FunctionalTests/RequestHeaderLimitsTests.cs:line 45
--- End of stack trace from previous location ---

@ghost ghost added the area-servers label Apr 24, 2020
@Pilchie
Copy link
Member

Pilchie commented Apr 24, 2020

👀

@Tratcher Tratcher mentioned this pull request Apr 24, 2020
Merged
@Pilchie
Copy link
Member

Pilchie commented Apr 25, 2020

Reran the failed legs, and adding auto-merge

@ghost
Copy link

ghost commented Apr 25, 2020

Hello @Pilchie!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2589a63 into master Apr 25, 2020
@ghost ghost deleted the rybrande/Quarnetine branch April 25, 2020 21:26
@halter73
Copy link
Member

This should be fixed by #21272.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanbrandenburg @Pilchie @halter73 @Tratcher @amcasey