Skip to content

Build aspnetcore for win-arm64 (#19317) #21227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2020
Merged

Build aspnetcore for win-arm64 (#19317) #21227

merged 2 commits into from
May 12, 2020

Conversation

JunTaoLuo
Copy link
Contributor

Addresses #21146

Build aspnetcore for win-arm64 (#19317)
05f58bb 
* Build for win-arm64

* Missed file

* Disable Selenium tests on arm64

* Include installers in the uploaded artifacts
@JunTaoLuo JunTaoLuo changed the base branch from master to release/3.1 April 27, 2020 07:39
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 27, 2020
@ryanbrandenburg
Copy link
Contributor

https://dev.azure.com/dnceng/public/_build/results?buildId=618748&view=logs&j=e3a5384c-bb27-5334-a10c-747a68c0a4ee&t=a6b98f8e-728d-56fa-dab1-81115ea86b79&l=2046 seems crossgen doesn't support ARM64 as of yet.

@JunTaoLuo JunTaoLuo marked this pull request as ready for review April 29, 2020 01:41
@JunTaoLuo JunTaoLuo requested a review from a team April 29, 2020 01:41
@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Apr 29, 2020 •
edited
Loading

Turns out our logic was updated in master to pick the correct crossgen but this is not the case in release/3.1. In any case, it looks like I fixed that issue, however, we don't really have a good way to verify the assets we produce. @tommcdon do you know if anyone can help us test the aspnetcore runtime?

@tommcdon
Copy link
Member

Turns out our logic was updated in master to pick the correct crossgen but this is not the case in release/3.1. In any case, it looks like I fixed that issue, however, we don't really have a good way to verify the assets we produce. @tommcdon do you know if anyone can help us test the aspnetcore runtime?

Hi @JunTaoLuo! Yes my team will take on the testing. Thank you very much for pulling together this PR!

@JunTaoLuo
Copy link
Contributor Author

@tommcdon Any updates on testing?

@tommcdon
Copy link
Member

@JunTaoLuo testing is complete

@JunTaoLuo JunTaoLuo merged commit bf9fbc0 into release/3.1 May 12, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/win-arm64-3.1 branch May 12, 2020 16:04
@Pilchie Pilchie added this to the 3.1.5 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
3.1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@JunTaoLuo @ryanbrandenburg @tommcdon @dougbu @Pilchie