[Templates] Update SPA dependencies to keep npm audit happy #21330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
ryanbrandenburg
approved these changes
May 4, 2020
mkArtakMSFT
approved these changes
May 5, 2020
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
dougbu
approved these changes
May 5, 2020
| "@types/jasmine": "~3.4.4", | ||
| "@types/jasminewd2": "~2.0.8", | ||
| "@types/node": "~12.11.6", | ||
| "codelyzer": "^5.2.0", | ||
| "jasmine-core": "~3.5.0", | ||
| "jasmine-spec-reporter": "~4.2.1", | ||
| "karma": "^4.4.1", | ||
| "karma": "^5.0.2", |
There was a problem hiding this comment.
Bit surprised we can bump the major version without adjusting some of our code 😃
leecow
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many of the node dependencies of SPA project templates have received updates including some security fixes. The current references the SPA project templates have are not up-to-date.
Customer Impact
Customers who create new project will end up using dependencies with known security vulnerabilities. Also, these will result in warnings printed when running newly created SPA projects.
Regression?
These dependencies are not something we have control over. We simply update them from time to time to keep the templates current and in good state.
Risk
Low: The change itself is a low-risk for us as there is no actual functionality change involved in our code.