Skip to content

Log type of ObjectResult in ObjectResultExecutor #21425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2020
Merged

Log type of ObjectResult in ObjectResultExecutor #21425

merged 2 commits into from
May 7, 2020

Conversation

andrewjsaid
Copy link
Contributor

Summary of the changes (Less than 80 chars)

  • ObjectResultExecutor logs derived type of ObjectResult.

Addresses #21393

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 2, 2020
rynowak
rynowak requested changes May 3, 2020
View reviewed changes
Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, this looks like the right idea, there are a few small changes I want to see.

@andrewjsaid
Copy link
Contributor Author

I re-pushed the same commit because the last checks ran out of memory and it didn't seem like a problem with the commit. We will see.

@rynowak rynowak merged commit b328f50 into dotnet:master May 7, 2020
@rynowak
Copy link
Member

rynowak commented May 7, 2020

Thanks!

@andrewjsaid andrewjsaid deleted the object-result-clearer-log branch May 7, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynowak rynowak rynowak approved these changes

Assignees

@pranavkm pranavkm

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewjsaid @rynowak @pranavkm