Add .version file to shared framework zip

[wtgodbe]

Manual port of #21548

Attempts to resolve #21177 by including a .version file in our shared framework zip, and a versions.txt file in our shared framework .nupkg. This more closely mimics what happens in microsoft.netcore.app

Testing confirms that the shared framework zips now contain .version in shared\Microsoft.AspNetCore.App\3.1.4, while the .nupkg still includes a versions.txt file.

[wtgodbe]

Expected file to exist at /private/tmp/helix/working/A9E30922/w/AC52095B/e/.dotnet32361/shared/Microsoft.AspNetCore.App/5.0.0-preview.5.20253.7/.version but it did not

It looks like in Helix, ASPNET_RUNTIME_PATH is set to the location of AspNetCore in the SDK, so ItContainsVersionFile and other similar tests aren't actually testing the shared framework we just built, they're testing the SDK we're using. @HaoK should we just disable these in Helix? How would we do that?

[HaoK]

Yeah looks like I might have messed up the conversion to C# of the install aspnet ref package code. I can take a look at fixing those, feel free to just add [SkipOnHelix("aspnet ref busted")] for the failing tests, and I'll open a PR to work on reenabling them with the TestRunner fix

[HaoK]

@wtgodbe Actually I spoke too soon, looks like these tests are looking at the shared fx not the ref pack, and I checked out the artifacts on the build: https://dev.azure.com/dnceng/public/_build/results?buildId=635302&view=artifacts&type=publishedArtifacts

in Runtime.win-x64.5.0.0-ci, I still see Microsoft.AspNetCore.App.vesrions.txt there, I don't see a .versions file, so I think its copying the built fx correctly, we just aren't producing the .version still

Found AspNetRuntime: Microsoft.AspNetCore.App.Runtime.win-x64.5.0.0-ci.nupkg, extracting *.txt,json,dll to /private/tmp/helix/working/A9E30922/w/AC52095B/e/.dotnet32361/shared/Microsoft.AspNetCore.App/5.0.0-preview.5.20253.7

Displaying directory contents for /private/tmp/helix/working/A9E30922/w/AC52095B/e/.dotnet32361/shared/Microsoft.AspNetCore.App/5.0.0-preview.5.20253.7:
Microsoft.AspNetCore.ResponseCaching.dll
Microsoft.AspNetCore.ResponseCompression.dll
Microsoft.AspNetCore.Rewrite.dll
Microsoft.AspNetCore.Cryptography.Internal.dll
Microsoft.AspNetCore.Connections.Abstractions.dll
Microsoft.Win32.SystemEvents.dll
Microsoft.AspNetCore.StaticFiles.dll
Microsoft.AspNetCore.Mvc.DataAnnotations.dll
Microsoft.Extensions.Localization.dll
Microsoft.Extensions.WebEncoders.dll
Microsoft.AspNetCore.Cors.dll
Microsoft.AspNetCore.Authorization.Policy.dll
Microsoft.Extensions.ObjectPool.dll
Microsoft.AspNetCore.DataProtection.dll
System.Security.Permissions.dll
Microsoft.AspNetCore.Cryptography.KeyDerivation.dll
Microsoft.AspNetCore.Localization.Routing.dll
Microsoft.AspNetCore.Identity.dll
Microsoft.Extensions.Identity.Core.dll
Microsoft.Net.Http.Headers.dll
Microsoft.AspNetCore.Session.dll
Microsoft.Extensions.Hosting.Abstractions.dll
Microsoft.Extensions.Logging.dll
Microsoft.AspNetCore.Http.Features.dll
Microsoft.AspNetCore.Components.Server.dll
Microsoft.AspNetCore.Http.Abstractions.dll
Microsoft.AspNetCore.CookiePolicy.dll
Microsoft.Extensions.Caching.Abstractions.dll
Microsoft.AspNetCore.Antiforgery.dll
Microsoft.Extensions.Logging.EventSource.dll
Microsoft.Extensions.Options.ConfigurationExtensions.dll
Microsoft.AspNetCore.Mvc.RazorPages.dll
Microsoft.AspNetCore.Http.Connections.Common.dll
Microsoft.Extensions.Logging.Abstractions.dll
Microsoft.AspNetCore.Razor.Runtime.dll
System.Security.Cryptography.Xml.dll
Microsoft.AspNetCore.Mvc.TagHelpers.dll
Microsoft.Extensions.Identity.Stores.dll
Microsoft.AspNetCore.Components.Web.dll
Microsoft.Extensions.Logging.Configuration.dll
Microsoft.Extensions.Configuration.UserSecrets.dll
Microsoft.AspNetCore.HttpsPolicy.dll
Microsoft.AspNetCore.App.versions.txt

[wtgodbe]

@HaoK we are producing the .version file now, but it goes in the shared framework .zip, while the versions.txt file goes in the .nupkg (which is what dotnet/runtime does as well). Does the test check different locations locally vs. in Helix?

[HaoK]

Ah interesting, yeah the helix test is working against the nupkg, and I'd guess the local tests are running against the shared framework, so for helix maybe the right thing to do is continue looking for the versions.txt? We could also considering sending both the zip and nupkg to helix and have explicit tests for both?

[wtgodbe]

@HaoK where does that infra live? If it's easy enough to implement either suggestion then I can do that as part of this PR, otherwise I'd rather disable the .version test on Helix for now and file a follow-up issue to fix the tests, as without this there's a broken scenario in the SDK

[HaoK]

Tactical fix for now could be to just have a helix guard around the expected file I guess? You can do a string.IsNullOrEmpty(Environment.GetEnvironmentVariable("ASPNET_RUNTIME_PATH")) check since this wouldn't be set locally to determine which file to look for

[wtgodbe]

Just pushed 582fe0d