Update contributing information to be more chronological#2197
Merged
Conversation
|
@jkotalik, |
Eilon
approved these changes
Sep 18, 2017
Contributor
Eilon
left a comment
Eilon
left a comment
There was a problem hiding this comment.
Looks great! Just 1 comment.
| **Obtaining the source code** | ||
|
|
||
| Before submitting a feature or substantial code contribution please discuss it with the team and ensure it follows the product roadmap. You might also read these two blogs posts on contributing code: [Open Source Contribution Etiquette](http://tirania.org/blog/archive/2010/Dec-31.html) by Miguel de Icaza and [Don't "Push" Your Pull Requests](https://www.igvita.com/2011/12/19/dont-push-your-pull-requests/) by Ilya Grigorik. Note that all code submissions will be rigorously reviewed and tested by the ASP.NET and Entity Framework teams, and only those that meet an extremely high bar for both quality and design/roadmap appropriateness will be merged into the source. | ||
| If you are an outside contributer, please fork the ASP.NET repository you would like to contribute to your account. See the github documentation for [forking a repo](https://help.github.com/articles/fork-a-repo/) if you have any questions about this. |
jkotalik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, I believe that the contributing section should be laid out in chronological order from "I see a fix I would like to make" to merging a pull request.
@natemcmaster @Eilon @davidfowl