-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Kestrel Endpoints' "SslProtocols" settable via config (#22663) #22910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kestrel Endpoints' "SslProtocols" settable via config (#22663) #22910
Conversation
I have tested the changes manually and they work ok. I have tried to write tests for the changes in KestrelConfigurationLoader but I didn't find a way to do so. I also realized that changing EndpointDefaults in config does not cause configuration to reload. Is that expected or should I create an issue for that? |
f14119b
to
0bc7f53
Compare
0bc7f53
to
4561eb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like the nits addressed, but no big deal.
Looks great. Thanks @fstaffa! |
fe5f099
to
a093450
Compare
a093450
to
8545552
Compare
Thanks |
Kestrel Endpoints' "SslProtocols" settable via config (#22663)
Priority of using SslProtocols is: