Fix helix-matrix tests #22918
Merged
Fix helix-matrix tests #22918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
force-pushed
the
johluo/fix-daily
branch
2 times, most recently
from
3878e5c to
6510970
Compare
JunTaoLuo
force-pushed
the
johluo/fix-daily
branch
from
6510970 to
3aa21c9
Compare
JunTaoLuo
commented
Jun 13, 2020
.azure/pipelines/ci.yml
Outdated
| @@ -606,7 +606,7 @@ stages: | |||
| - script: ./build.cmd -ci -nobl -noBuildRepoTasks -restore -noBuild -projects src/Grpc/**/*.csproj | |||
| displayName: Restore interop projects | |||
| - script: ./build.cmd -ci -nobl -noBuildRepoTasks -noRestore -test -all -noBuildNative -projects eng\helix\helix.proj | |||
| /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true | |||
| /p:IsHelixDaily=true /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true | |||
There was a problem hiding this comment.
Revert before merging
Pilchie
added
the
area-infrastructure
Tratcher
reviewed
Jun 15, 2020
JunTaoLuo
force-pushed
the
johluo/fix-daily
branch
from
3034e8c to
8e3e2e8
Compare
JunTaoLuo
force-pushed
the
johluo/fix-daily
branch
from
8e3e2e8 to
8df2ca5
Compare
JunTaoLuo
force-pushed
the
johluo/fix-daily
branch
from
4bf11fa to
36e9879
Compare
Tratcher
approved these changes
Jun 16, 2020
|
The tests in question have passed on all Windows queues so I'm considering this fixed. Reverting the helix matrix switch and merging soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #22917.