Skip to content

Add support for optional FromBody parameters (#22634) #23246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2020
Merged

Add support for optional FromBody parameters (#22634) #23246

merged 2 commits into from
Jun 23, 2020

Conversation

pranavkm
Copy link
Contributor

Cherry-pick #22634 to preview7

pranavkm added 2 commits June 22, 2020 16:57
@pranavkm
Add support for optional FromBody parameters (#22634)
0709629 
* Add support for optional FromBody parameters

Fixes #6878

* Fixup nullable

* Changes per API review
@pranavkm
Fixup doc comment (#23229)
7fcc9ad
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 22, 2020
@pranavkm pranavkm added this to the 5.0.0-preview7 milestone Jun 22, 2020
@ghost
Copy link

ghost commented Jun 23, 2020

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 56 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jun 23, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-preview7 is a protected branch and I have not been granted permission to perform the merge.

1 similar comment
@ghost
Copy link

ghost commented Jun 23, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-preview7 is a protected branch and I have not been granted permission to perform the merge.

@mkArtakMSFT mkArtakMSFT merged commit baf7e6c into release/5.0-preview7 Jun 23, 2020
@mkArtakMSFT mkArtakMSFT deleted the prkrishn/optional-frombody branch June 23, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
5.0.0-preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavkm @BrennanConroy @mkArtakMSFT