Skip to content

Dispose MemoryStream in DataProtectorTokenProvider #23344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Dispose MemoryStream in DataProtectorTokenProvider #23344

wants to merge 1 commit into from

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Jun 25, 2020

Fixes #23271

@ghost ghost added the area-identity Includes: Identity and providers label Jun 25, 2020
@gfoidl
Copy link
Member

gfoidl commented Jun 25, 2020

Cf. #9339
I still wouldn't dispose it, as it's private use and the "sub-class problem" (custom dispose-logic) doesn't apply here.

@mkArtakMSFT
Copy link
Contributor

Thanks for your PR.
@HaoK can you please look into this? Thanks!

@HaoK
Copy link
Member

HaoK commented Jun 29, 2020

Yep not worth it, thanks for the PR anyways!

@HaoK HaoK closed this Jun 29, 2020
@Kahbazi
Copy link
Member Author

Kahbazi commented Jun 30, 2020

@HaoK Should this issue be closed too? #23271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HaoK HaoK

Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undisposed MemoryStream
4 participants
@Kahbazi @gfoidl @mkArtakMSFT @HaoK