Skip to content

[master] Update dependencies from dotnet/efcore dotnet/runtime #24876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 13, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 68568747-40a2-4823-fae6-08d7f76e4602
  • Build: 20200815.1
  • Date Produced: 8/15/2020 10:02 AM
  • Commit: f35d747e8d7fe44d7dab76b9683d7c642ec26888
  • Branch: refs/heads/master
  • Updates:
    • System.ComponentModel.Annotations: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Diagnostics.DiagnosticSource: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Diagnostics.EventLog: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Logging: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Logging.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Logging.Configuration: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Logging.Console: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Logging.Debug: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Logging.EventLog: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Logging.EventSource: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Logging.TraceSource: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Options: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Options.ConfigurationExtensions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Options.DataAnnotations: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Primitives: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Internal.Transport: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Http: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Hosting: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Caching.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Caching.Memory: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration.Binder: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration.CommandLine: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration.EnvironmentVariables: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration.FileExtensions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration.Ini: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration.Json: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration.UserSecrets: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Configuration.Xml: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.DependencyInjection: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.DependencyInjection.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.DependencyModel: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.FileProviders.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.FileProviders.Composite: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.FileProviders.Physical: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.FileSystemGlobbing: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.HostFactoryResolver.Sources: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Extensions.Hosting.Abstractions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.NETCore.App.Runtime.win-x64: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.NETCore.Platforms: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Win32.Registry: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.Win32.SystemEvents: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.NETCore.App.Internal: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • Microsoft.NETCore.App.Ref: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Drawing.Common: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Text.Encodings.Web: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Text.Json: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Threading.Channels: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Windows.Extensions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.ServiceProcess.ServiceController: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Security.Principal.Windows: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.IO.Pipelines: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Net.Http.Json: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Net.Http.WinHttpHandler: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Net.WebSockets.WebSocketProtocol: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Reflection.Metadata: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Resources.Extensions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Runtime.CompilerServices.Unsafe: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Security.AccessControl: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Security.Cryptography.Cng: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Security.Cryptography.Pkcs: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Security.Cryptography.Xml: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1
    • System.Security.Permissions: from 5.0.0-rc.1.20411.5 to 5.0.0-rc.1.20415.1

From https://github.com/dotnet/efcore

  • Subscription: ccafa991-4408-48df-d45d-08d76e1d3434
  • Build: 20200814.11
  • Date Produced: 8/15/2020 4:52 AM
  • Commit: 6190dac76942ab946106f0ddcf507d98ef51bbed
  • Branch: refs/heads/main
  • Updates:
    • Microsoft.EntityFrameworkCore.Tools: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
    • Microsoft.EntityFrameworkCore.SqlServer: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
    • dotnet-ef: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
    • Microsoft.EntityFrameworkCore: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
    • Microsoft.EntityFrameworkCore.Relational: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
    • Microsoft.EntityFrameworkCore.Sqlite: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11
    • Microsoft.EntityFrameworkCore.InMemory: from 5.0.0-rc.1.20412.5 to 5.0.0-rc.1.20414.11

…0812.8

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting.Abstractions , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.AccessControl , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions
 From Version 5.0.0-rc.1.20411.5 -> To Version 5.0.0-rc.1.20412.8
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner August 13, 2020 14:29
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Aug 13, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 13, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

…813.2

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20412.5 -> To Version 5.0.0-rc.1.20413.2
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from dotnet/runtime [master] Update dependencies from dotnet/runtime dotnet/efcore Aug 13, 2020
…813.4

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20412.5 -> To Version 5.0.0-rc.1.20413.4
@dougbu
Copy link
Contributor

dougbu commented Aug 14, 2020

@JunTaoLuo @JamesNK seeing very consistent failures across the board for the gRPC functional tests in this PR. Any suggestions❔

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@JunTaoLuo
Copy link
Contributor

Hmm something broke the client:

[xUnit.net 00:00:09.39]       Client process output:
[xUnit.net 00:00:09.39]       ======================================
[xUnit.net 00:00:09.39]       Application started.
[xUnit.net 00:00:09.39]       NetCoreAppVersion: 5.0.0-rc.1.20412.8+0db8ecbea291c09cfd84d7f33ea049f5c0cec94f
[xUnit.net 00:00:09.39]       Use TLS: False
[xUnit.net 00:00:09.39]       Use Test CA: False
[xUnit.net 00:00:09.39]       Client type: httpclient
[xUnit.net 00:00:09.39]       Server host: localhost
[xUnit.net 00:00:09.39]       Server port: 38719
[xUnit.net 00:00:09.39]       running special_status_message
[xUnit.net 00:00:09.39]       �[40m�[37mdbug�[39m�[22m�[49m: Grpc.Net.Client.Internal.GrpcCall[1]
[xUnit.net 00:00:09.39]             => GrpcMethodType:Unary GrpcUri:/grpc.testing.TestService/UnaryCall
[xUnit.net 00:00:09.39]             Starting gRPC call. Method type: 'Unary', URI: 'http://localhost:38719/grpc.testing.TestService/UnaryCall'.
[xUnit.net 00:00:09.39]       �[40m�[37mdbug�[39m�[22m�[49m: Grpc.Net.Client.Internal.GrpcCall[18]
[xUnit.net 00:00:09.39]             => GrpcMethodType:Unary GrpcUri:/grpc.testing.TestService/UnaryCall
[xUnit.net 00:00:09.39]             Sending message.
[xUnit.net 00:00:09.39]       �[40m�[37mtrce�[39m�[22m�[49m: Grpc.Net.Client.Internal.GrpcCall[21]
[xUnit.net 00:00:09.39]             => GrpcMethodType:Unary GrpcUri:/grpc.testing.TestService/UnaryCall
[xUnit.net 00:00:09.39]             Serialized 'Grpc.Testing.SimpleRequest' to 68 byte message.
[xUnit.net 00:00:09.39]       �[40m�[37mtrce�[39m�[22m�[49m: Grpc.Net.Client.Internal.GrpcCall[19]
[xUnit.net 00:00:09.39]             => GrpcMethodType:Unary GrpcUri:/grpc.testing.TestService/UnaryCall
[xUnit.net 00:00:09.39]             Message sent.
[xUnit.net 00:00:09.39]       �[41m�[30mfail�[39m�[22m�[49m: Grpc.Net.Client.Internal.GrpcCall[6]
[xUnit.net 00:00:09.39]             => GrpcMethodType:Unary GrpcUri:/grpc.testing.TestService/UnaryCall
[xUnit.net 00:00:09.39]             Error starting gRPC call.
[xUnit.net 00:00:09.39]             System.Net.Http.HttpRequestException: An error occurred while sending the request.
[xUnit.net 00:00:09.39]              ---> System.IO.IOException: The response ended prematurely.
[xUnit.net 00:00:09.39]                at System.Net.Http.HttpConnection.FillAsync(Boolean async)
[xUnit.net 00:00:09.39]                at System.Net.Http.HttpConnection.ReadNextResponseHeaderLineAsync(Boolean async, Boolean foldedHeadersAllowed)
[xUnit.net 00:00:09.39]                at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
[xUnit.net 00:00:09.39]                --- End of inner exception stack trace ---
[xUnit.net 00:00:09.39]                at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
[xUnit.net 00:00:09.39]                at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
[xUnit.net 00:00:09.39]                at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
[xUnit.net 00:00:09.39]                at System.Net.Http.DiagnosticsHandler.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
[xUnit.net 00:00:09.39]                at System.Net.Http.HttpClient.FinishSendAsync(ValueTask`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts, Boolean buffered, Boolean async, CancellationToken callerToken, Int64 timeoutTime)
[xUnit.net 00:00:09.39]                at Grpc.Net.Client.Internal.GrpcCall`2.RunCall(HttpRequestMessage request)
[xUnit.net 00:00:09.39]       �[40m�[37mdbug�[39m�[22m�[49m: Grpc.Net.Client.Internal.GrpcCall[8]
[xUnit.net 00:00:09.39]             => GrpcMethodType:Unary GrpcUri:/grpc.testing.TestService/UnaryCall
[xUnit.net 00:00:09.39]             gRPC call canceled.
[xUnit.net 00:00:09.39]       �[41m�[30mfail�[39m�[22m�[49m: Grpc.Net.Client.Internal.GrpcCall[3]
[xUnit.net 00:00:09.39]             => GrpcMethodType:Unary GrpcUri:/grpc.testing.TestService/UnaryCall
[xUnit.net 00:00:09.39]             Call failed with gRPC error status. Status code: 'Internal', Message: 'Error starting gRPC call: An error occurred while sending the request.'.
[xUnit.net 00:00:09.39]       �[40m�[37mdbug�[39m�[22m�[49m: Grpc.Net.Client.Internal.GrpcCall[4]
[xUnit.net 00:00:09.39]             => GrpcMethodType:Unary GrpcUri:/grpc.testing.TestService/UnaryCall
[xUnit.net 00:00:09.39]             Finished gRPC call.
[xUnit.net 00:00:09.39]       ERROR: Unhandled exception. System.InvalidOperationException: Expected Unknown but got Internal.
[xUnit.net 00:00:09.39]       ERROR:    at InteropTestsClient.Assert.AreEqual(Object expected, Object actual) in F:\workspace\_work\1\s\src\Grpc\test\testassets\InteropClient\Assert.cs:line 47
[xUnit.net 00:00:09.39]       ERROR:    at InteropTestsClient.InteropClient.RunSpecialStatusMessageAsync(TestServiceClient client) in F:\workspace\_work\1\s\src\Grpc\test\testassets\InteropClient\InteropClient.cs:line 676
[xUnit.net 00:00:09.39]       ERROR:    at InteropTestsClient.InteropClient.RunTestCaseAsync(IChannelWrapper channel, ClientOptions options) in F:\workspace\_work\1\s\src\Grpc\test\testassets\InteropClient\InteropClient.cs:line 267
[xUnit.net 00:00:09.39]       ERROR:    at InteropTestsClient.InteropClient.Run() in F:\workspace\_work\1\s\src\Grpc\test\testassets\InteropClient\InteropClient.cs:line 139
[xUnit.net 00:00:09.39]       ERROR:    at InteropTestsClient.InteropClient.<>c.<Run>b__7_1(ClientOptions options) in F:\workspace\_work\1\s\src\Grpc\test\testassets\InteropClient\InteropClient.cs:line 131
[xUnit.net 00:00:09.39]       ERROR:    at CommandLine.ParserResultExtensions.WithParsed[T](ParserResult`1 result, Action`1 action)
[xUnit.net 00:00:09.39]       ERROR:    at InteropTestsClient.InteropClient.Run(String[] args) in F:\workspace\_work\1\s\src\Grpc\test\testassets\InteropClient\InteropClient.cs:line 119
[xUnit.net 00:00:09.39]       ERROR:    at InteropTestsClient.Program.Main(String[] args) in F:\workspace\_work\1\s\src\Grpc\test\testassets\InteropClient\Program.cs:line 33

@dotnet-maestro
Copy link
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@JamesNK
Copy link
Member

JamesNK commented Aug 14, 2020

I think I know what the problem is. There is a new setting in HttpClient around pre-negotiating H2C. It disables the current appcontext switch - dotnet/runtime#39201

Two options:

  1. Change the interop tests to use TLS
  2. Disable them until there is a grpc-dotnet release that targets .NET 5 and uses the new setting

Option 2 is fast and easy.
Option 1 would be preferable. Running the interop tests under both H2C is a good idea anyway. We can add the option, do H2 only for now, and test both once H2 and H2C when possible.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 14, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@dougbu
Copy link
Contributor

dougbu commented Aug 14, 2020

I'd lean toward "Change the interop tests to use TLS" if that's something you or @JunTaoLuo could do soon-ish because I feel qualified only on the "Disable them until there is a grpc-dotnet release that targets .NET 5 and uses the new setting" option.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 14, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@JamesNK
Copy link
Member

JamesNK commented Aug 14, 2020

Short term for this PR: Ignore the interop tests.

I will investigate re-enabling them once the PR is merged.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 14, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: aspnetcore-quarantined-pr, aspnetcore-ci, aspnetcore-quarantined-pr (Tests: Windows x64), aspnetcore-quarantined-pr (Tests: Ubuntu 16.04 x64), aspnetcore-quarantined-pr (Tests: macOS 10.14), aspnetcore-quarantined-pr (Tests: Helix), aspnetcore-ci (Build Test: Linux Source Build), aspnetcore-ci (Build Test: macOS 10.14), aspnetcore-ci (Build Test: Ubuntu 16.04 x64), aspnetcore-ci (Build Tests: Helix x64), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Build: Linux Musl x64), aspnetcore-ci (Build Build: Linux Musl ARM64), aspnetcore-ci (Build Build: macOS), aspnetcore-ci (Build Build: Linux ARM64), aspnetcore-ci (Build Build: Linux x64), aspnetcore-ci (Build Build: Linux ARM), aspnetcore-ci (Build Build: Windows ARM64), aspnetcore-ci (Build Code check), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Build: Windows ARM)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@dougbu
Copy link
Contributor

dougbu commented Aug 14, 2020

Short term for this PR: Ignore the interop tests.

Done. Suspect some of the quarantined tests should also be skipped but I didn't go that deep.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 14, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@dougbu
Copy link
Contributor

dougbu commented Aug 14, 2020

Ah, my work here isn't done. Most, if not all, of the tests in HttpClientHttp2InteropTests also need to be skipped when given "http" (tests seem fine when given "https"). Tomorrow…

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 14, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: aspnetcore-quarantined-pr, aspnetcore-ci, aspnetcore-quarantined-pr (Tests: Helix), aspnetcore-ci (Build Tests: Helix x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

…813.8

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20412.5 -> To Version 5.0.0-rc.1.20413.8
…0814.1

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting.Abstractions , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.AccessControl , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions
 From Version 5.0.0-rc.1.20411.5 -> To Version 5.0.0-rc.1.20414.1
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from dotnet/runtime dotnet/efcore [master] Update dependencies from dotnet/efcore dotnet/runtime Aug 14, 2020
…814.1

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20412.5 -> To Version 5.0.0-rc.1.20414.1
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from dotnet/efcore dotnet/runtime [master] Update dependencies from dotnet/runtime dotnet/efcore Aug 14, 2020
- try just removing "http" theory data
…814.4

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20412.5 -> To Version 5.0.0-rc.1.20414.4
…814.7

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20412.5 -> To Version 5.0.0-rc.1.20414.7
@dougbu
Copy link
Contributor

dougbu commented Aug 15, 2020

Checked one of the builds interrupted by a new efcore or runtime build. Errors didn't seem to get a chance to show up here but my previous commit causes xUnit errors on at least OSX.1014.Amd64.Open because test data is empty e.g

ServerReset_AfterTrailers_NoError [FAIL]
  System.InvalidOperationException : No data found for Interop.FunctionalTests.HttpClientHttp2InteropTests.ServerReset_AfterTrailers_NoError

Need to skip tests on that platform.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 15, 2020

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: aspnetcore-quarantined-pr, aspnetcore-ci, aspnetcore-quarantined-pr (Tests: Helix), aspnetcore-quarantined-pr (Tests: macOS 10.14), aspnetcore-quarantined-pr (Tests: Windows x64), aspnetcore-quarantined-pr (Tests: Ubuntu 16.04 x64), aspnetcore-ci (Build Test: Linux Source Build), aspnetcore-ci (Build Tests: Helix x64), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: macOS 10.14), aspnetcore-ci (Build Test: Ubuntu 16.04 x64), aspnetcore-ci (Build Build: Linux Musl x64), aspnetcore-ci (Build Build: Linux Musl ARM64), aspnetcore-ci (Build Build: Windows ARM64), aspnetcore-ci (Build Build: macOS), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Build: Windows ARM), aspnetcore-ci (Build Build: Linux ARM64), aspnetcore-ci (Build Code check), aspnetcore-ci (Build Build: Linux x64), aspnetcore-ci (Build Build: Linux ARM)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot and others added 5 commits August 15, 2020 03:17
…814.8

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20412.5 -> To Version 5.0.0-rc.1.20414.8
…814.10

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20412.5 -> To Version 5.0.0-rc.1.20414.10
- no theory data due to #24902 and dotnet/corefx#30492 aka dotnet/runtime#26534 (now tracked somewhere else)
…814.11

Microsoft.EntityFrameworkCore.Tools , Microsoft.EntityFrameworkCore.SqlServer , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.InMemory
 From Version 5.0.0-rc.1.20412.5 -> To Version 5.0.0-rc.1.20414.11
…0815.1

System.ComponentModel.Annotations , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Extensions.Internal.Transport , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting.Abstractions , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry , Microsoft.Win32.SystemEvents , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref , System.Drawing.Common , System.Text.Encodings.Web , System.Text.Json , System.Threading.Channels , System.Windows.Extensions , System.ServiceProcess.ServiceController , System.Security.Principal.Windows , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Net.WebSockets.WebSocketProtocol , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.CompilerServices.Unsafe , System.Security.AccessControl , System.Security.Cryptography.Cng , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions
 From Version 5.0.0-rc.1.20411.5 -> To Version 5.0.0-rc.1.20415.1
@dotnet-maestro dotnet-maestro bot changed the title [master] Update dependencies from dotnet/runtime dotnet/efcore [master] Update dependencies from dotnet/efcore dotnet/runtime Aug 15, 2020
@dotnet-maestro dotnet-maestro bot merged commit 3f40882 into master Aug 15, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-8caab1f0-8cdd-409a-981c-fa2c70771a7e branch August 15, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants