-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Allow suppressing the use of environment variables #25136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why is this on the HostBuilder? |
Because it has to be called before ConfigureWebHost/Defaults in order to affect their behavior. |
This needs an API review. I'm not a fan of having this be an extension method on the IHostBuilder that affects the webshost builder scenario. We might need another way to do this (like passing a bool to ConfigureWebHost). |
7cb8f60
to
0d66550
Compare
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
6216bf1
to
16830f9
Compare
Co-authored-by: Kahbazi <[email protected]>
Hello @Tratcher! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
#20328 The GenericWebHost and WebHostBuilder automatically add a config provider for "ASPNETCORE_" environment variables with no opportunity to disable it. This is problematic for:
This change adds an option to suppress environment based config.