[release/3.1] Correct baseline checks #25217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
dougbu
force-pushed
the
dougbu/fixup.baselines
branch
from
83c2ace to
26cd396
Compare
dougbu
added
the
blocked
|
Blocked until branch opens for 3.1.9. But, please review soon-ish so we're ready😺 |
dougbu
added a commit
that referenced
this pull request
Aug 25, 2020
- mostly duplicates #25217 - update `BaselineGenerator` to produce baselines useful in 6.0 (too) - update Baseline.Designer.props using new generator (matching 3.1.7 release) - always suppress references expressed only in `*.nuspec` files - needed even in servicing builds - restore warning and errors about removed references (new for 5.0) - adjust exclusions to handle `@(_ProjectReferenceByAssemblyName)` removal nit: do not generate empty `<ItemGroup />` elements
wtgodbe
approved these changes
Aug 25, 2020
dougbu
added a commit
that referenced
this pull request
Aug 25, 2020
- mostly duplicates #25217 - update `BaselineGenerator` to produce baselines useful in 6.0 (too) - update Baseline.Designer.props using new generator (matching 3.1.7 release) - always suppress references expressed only in `*.nuspec` files - needed even in servicing builds - restore warning and errors about removed references (new for 5.0) - adjust exclusions to handle `@(_ProjectReferenceByAssemblyName)` removal nit: do not generate empty `<ItemGroup />` elements
dougbu
added a commit
that referenced
this pull request
Aug 28, 2020
- mostly duplicates #25217 - update `BaselineGenerator` to produce baselines useful in 6.0 (too) - update Baseline.Designer.props using new generator (matching 3.1.7 release) - always suppress references expressed only in `*.nuspec` files - needed even in servicing builds - restore warning and errors about removed references (new for 5.0) - adjust exclusions to handle `@(_ProjectReferenceByAssemblyName)` removal nit: do not generate empty `<ItemGroup />` elements
dougbu
added a commit
that referenced
this pull request
Aug 28, 2020
- mostly duplicates #25217 - update `BaselineGenerator` to produce baselines useful in 6.0 (too) - update Baseline.Designer.props using new generator (matching 3.1.7 release) - always suppress references expressed only in `*.nuspec` files - needed even in servicing builds - restore warning and errors about removed references (new for 5.0) - adjust exclusions to handle `@(_ProjectReferenceByAssemblyName)` removal nit: do not generate empty `<ItemGroup />` elements * Correct `@(SuppressBaselineReference)` items - remove out-of-date `@(SuppressBaselineReference)` items - either 3.1.7 baselines we're using don't include reference or still using package - fix some comments and `Condition` attributes to make remainder easy to find - add missing `@(SuppressBaselineReference)` items
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- disable use of `@(SuppressBaselineReference)` items while servicing - update `BaselineGenerator` to produce baselines useful in 5.0 - update Baseline.Designer.props using new generator nit: do not generate empty `<ItemGroup />` elements
dougbu
force-pushed
the
dougbu/fixup.baselines
branch
from
abe386e to
09a6539
Compare
dougbu
removed
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@(SuppressBaselineReference)items while servicingBaselineGeneratorto produce baselines useful in 5.0nit: do not generate empty
<ItemGroup />elements