Set SameSiteMode for cookies in authentication tests #25281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
approved these changes
Aug 26, 2020
|
FYI @BrennanConroy |
javiercn
approved these changes
Aug 26, 2020
|
Merging this without waiting for the checks to pass as this is blocking many other PRs. |
|
Do the wasm tests not run cross origin? |
|
There's still the issue with the java tests, right? |
@javiercn If we have a template for Blazor WASM + Identity server, we might want to consider including the same SameSite guards that we use in our OIDC sample (ref). Alternatively, we can document it and refer users to blog posts like this one.
Not these particular tests. They run on a hosted Blazor WASM app running on a single port. |
captainsafia
added a commit
that referenced
this pull request
Aug 27, 2020
dougbu
pushed a commit
that referenced
this pull request
Aug 30, 2020
wtgodbe
pushed a commit
that referenced
this pull request
Sep 8, 2020
* Set SameSiteMode for cookies in authentication tests (#25281) * Fix SignalR typescript tests with Chrome SameSite reaction (#25283) * Disable template tests that use Selenium Co-authored-by: Brennan <[email protected]> Co-authored-by: Doug Bunting <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome (as of v80) enforces a strict check on cookie settings. Cookies set with SameSiteMode=None must be marked as secure.
The Identity.Server sets the SameSiteMode to None by default. This PR sets the SameSiteMode to
Laxby default since the WASM auth tests do not run on an HTTPS server.I verified this by confirming that a Register -> Log in -> visit preferences flow works on the Authentication app.