Skip to content

Disable failing/hanging tests due to Chrome/Selenium issue #25323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

JunTaoLuo
Copy link
Contributor

Disabling tests to unblock CI. Issue tracking re-enabling tests at #25322

@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Aug 27, 2020
@JunTaoLuo JunTaoLuo requested review from SteveSandersonMS and a team as code owners August 27, 2020 18:59
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@wtgodbe
Copy link
Member

wtgodbe commented Aug 27, 2020

@JunTaoLuo Helix x64 was green before this change, so this has fixed everything that was failing! Any opposition to merging this now?

@JunTaoLuo JunTaoLuo merged commit 7b8fe53 into release/5.0 Aug 27, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/disable-chrome-tests branch August 27, 2020 20:16
JunTaoLuo pushed a commit that referenced this pull request Aug 27, 2020
JunTaoLuo pushed a commit that referenced this pull request Sep 10, 2020
JunTaoLuo pushed a commit that referenced this pull request Sep 11, 2020
* Revert "Disable failing/hanging tests due to Chrome/Selenium issue (#25323)"

This reverts commit 332f150.

* Update Selenium to latest

* Update API

* Try specifying a version

* Update Selenium to 4.0.0-beta5

* Disable browser log tests

* Fix components e2e tests and disable blazor standalone template test
JunTaoLuo pushed a commit that referenced this pull request Sep 12, 2020
* Revert "Disable failing/hanging tests due to Chrome/Selenium issue (#25323)"

This reverts commit 332f150.

* Update Selenium to latest

* Update API

* Try specifying a version

* Update Selenium to 4.0.0-beta5

* Disable browser log tests

* Fix components e2e tests and disable blazor standalone template test
JunTaoLuo pushed a commit that referenced this pull request Sep 15, 2020
* Fix chrome/selenium tests (#25330)

* Revert "Disable failing/hanging tests due to Chrome/Selenium issue (#25323)"

This reverts commit 332f150.

* Update Selenium to latest

* Update API

* Try specifying a version

* Update Selenium to 4.0.0-beta5

* Disable browser log tests

* Fix components e2e tests and disable blazor standalone template test

* Disable tests using browser log

* Disable template test

* Avoid using .NET formatted strings in tests

* Annotate BasicTestApp suggesting that it needs the all globalization data

* Culture specific formatting relies on the ICU data carried by the OS. This
causes issues in our tests if WebAssembly carries a different set than the OS. Instead
updating these tests to use hardcoded strings.

* Additionally fixing an issue where some projects in the solution were using tasks from
the .dotnet SDK rather than the local copy of the SDK. This was causing issues building locally.

Co-authored-by: Pranav K <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants