Add PublicAPI baselines for Middleware #25602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
area-infrastructure
Tratcher
reviewed
Sep 4, 2020
| #nullable enable | ||
| Microsoft.AspNetCore.Builder.CorsEndpointConventionBuilderExtensions | ||
| Microsoft.AspNetCore.Builder.CorsMiddlewareExtensions | ||
| Microsoft.AspNetCore.Cors.CorsPolicyMetadata |
There was a problem hiding this comment.
How do these Unshipped and Shipped files work? I'd expect Unshipped to be the APIs new to 5.0 and Shipped to be the 3.1 baseline? Most of the APIs in this Unshipped file are not new.
There was a problem hiding this comment.
We manually move to the Shipped file once we ship. Right now I'm just trying to get everything into the unshipped files as a baseline, and then we'll take our 5.0 surface area and move it to shipped at once.
Tratcher
approved these changes
Sep 4, 2020
|
@dougbu - any objections to me merging? |
dougbu
approved these changes
Sep 4, 2020
Not really though we shouldn't leave |
amcasey
added
the
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.