Skip to content

[release/5.0-rc2] Add public API baselines for HTML and HTTP #25638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Sep 4, 2020

nits: take a few VS suggestions in opened files

  • e.g. use pattern matching and using statements a bit more

@dougbu dougbu requested review from JamesNK, Pilchie, jkotalik and a team September 4, 2020 23:55
@dougbu
Copy link
Contributor Author

dougbu commented Sep 5, 2020

Hold up, my branch is out-of-date. Need to re-up the baseline files

@dougbu dougbu force-pushed the dougbu/add.baselines.ht branch 2 times, most recently from 0d47a16 to eb0e2c7 Compare September 5, 2020 01:41
- part of #24347

nits: take a few VS suggestions in opened files
- e.g. use pattern matching and `using` statements a bit more
- revert suppression in an AssemblyInfo.cs file
- generally avoid manual edits to baseline files but just this once…
@dougbu dougbu force-pushed the dougbu/add.baselines.ht branch from eb0e2c7 to 64551a0 Compare September 6, 2020 02:39
@dougbu
Copy link
Contributor Author

dougbu commented Sep 6, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 6, 2020
@dougbu dougbu merged commit ad5e173 into release/5.0-rc2 Sep 6, 2020
@dougbu dougbu deleted the dougbu/add.baselines.ht branch September 6, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants