Send CloseMessage in more cases #25693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Back port? |
We can consider it once this is merged |
|
/azp run aspnetcore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
halter73
reviewed
Sep 9, 2020
| @@ -226,7 +226,7 @@ private async Task SendCloseAsync(HubConnectionContext connection, Exception? ex | |||
|
|
|||
| try | |||
| { | |||
| await connection.WriteAsync(closeMessage); | |||
| await connection.WriteCloseAsync(closeMessage); | |||
There was a problem hiding this comment.
I prefer adding an ignoreAbort = false parameter to WriteAsync. Where it checks if (_connectionAborted) today, we'd change that to if (_connectionAborted && !ignoreAbort). That way if we make a change to WriteAsync in the future, we get it for free without having to remember to also update WriteCloseAsync.
There was a problem hiding this comment.
and add a branch to every single write!? 😮
There was a problem hiding this comment.
But the branch is already there 😆
halter73
reviewed
Sep 9, 2020
halter73
approved these changes
Sep 10, 2020
|
@Pilchie for RC2 |
|
Approved for .NET 5 RC2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CloseMessage(allowReconnect: false)was not being sent whenContext.Abort()was called, which resulted in clients potentially attempting a reconnect. This fixes it so that theCloseMessagecan be sent now so well behaved clients wont attempt an unwanted reconnect.Fixes #21422