Skip to content

Reorganize Versions files to indicate compilers is not automated #26329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

Reorganize Versions files to indicate compilers is not automated #26329

merged 1 commit into from
Sep 25, 2020

Conversation

pranavkm
Copy link
Contributor

No description provided.

@pranavkm pranavkm requested a review from dougbu as a code owner September 25, 2020 16:48
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 25, 2020
@pranavkm pranavkm added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 25, 2020
@pranavkm pranavkm added this to the 5.0.0-rc2 milestone Sep 25, 2020
dougbu
dougbu approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

BTW I'm not sure it matters but aspnetcore-tooling uses Microsoft.Net.Compilers.Toolset v3.8.0-3.20454.4. May want to match the more recent version here.

@pranavkm
Copy link
Contributor Author

I think we're newer than them:

AspNetCore-Tooling: 3.8.0-3.20454.4
AspNetCore: 3.8.0-3.20458.6

@dougbu
Copy link
Contributor

dougbu commented Sep 25, 2020

I think we're newer than them:

Agreed. I meant we may want to update aspnetcore-tooling to match aspnetcore

This was referenced Sep 25, 2020
Closed
Closed
@pranavkm
Copy link
Contributor Author

@dougbu could you merge this please?

@dougbu dougbu merged commit fe23ee7 into release/5.0-rc2 Sep 25, 2020
@dougbu dougbu deleted the prkrishn/netcore-cleanup branch September 25, 2020 21:41
@dougbu
Copy link
Contributor

dougbu commented Sep 25, 2020

Please prepare a 'release/5.0' PR since this didn't make the cut off.

@dagood dagood mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
5.0.0-rc2
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavkm @dougbu