Fix virtualization culture invariance #26432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
|
I can work on getting this thru tactics. |
javiercn
approved these changes
Sep 29, 2020
JamesNK
approved these changes
Sep 29, 2020
|
We need to get culture analyzers turned on - #24567 |
pranavkm
added
Servicing-approved
|
@dotnet/aspnet-build could you merge this? |
ajaybhargavb
deleted the
stevesa/fix-virtualization-culture-invariance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26424
Description
Blazor's virtualization uses culture-specific formatting (
ToString()) when emitting values for css heights. In cultures that use decimal separators for their heights, the generated height is not a valid css value. This change updates the heights to use invariant formatting.Customer impact
The Virtualize component does not function when executing in non-English locales. This affects both Blazor Server with request localization and Blazor WebAssembly.
Regression
No. The feature is new to .NET 5 RC1.
Risk
The change is isolated to the Virtualize component and was tested manually.