Consume ValueTask with GetAwaiter().GetResult() #29710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kahbazi
requested review from
halter73,
jkotalik,
Tratcher and
a team
as code owners
javiercn
added
the
community-contribution
javiercn
reviewed
Jan 28, 2021
| @@ -236,6 +236,9 @@ public Task DisposeInBatchAsync(RenderBatchBuilder batchBuilder) | |||
| var result = ((IAsyncDisposable)Component).DisposeAsync(); | |||
| if (result.IsCompletedSuccessfully) | |||
| { | |||
| // If it's a IValueTaskSource backed ValueTask, | |||
| // inform it its result has been read so it can reset | |||
| result.GetAwaiter().GetResult(); | |||
There was a problem hiding this comment.
@davidfowl do we need to do this across all places where we consume ValueTask?
There was a problem hiding this comment.
Yes. There's an uber issue with a bunch of violations in our code base wrt value task. @stephentoub filed the issue in 5.0 we should address those things in 6.0
There was a problem hiding this comment.
Looks like it's #16876. Might as well go ahead and take this if someone wants to sign off on it.
javiercn
approved these changes
Jan 28, 2021
davidfowl
approved these changes
Jan 28, 2021
|
Thanks @Kahbazi ! |
|
Hi @Pilchie. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.