Skip to content

Delete pr-validation-temp.yml#29731

Merged
wtgodbe merged 1 commit intorelease/2.1from
wtgodbe/RemovePRTemp
Feb 10, 2021
Merged

Delete pr-validation-temp.yml#29731
wtgodbe merged 1 commit intorelease/2.1from
wtgodbe/RemovePRTemp

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 28, 2021

This is no longer needed now that 2.1 builds in AzDO

@wtgodbe wtgodbe requested a review from a team January 28, 2021 20:26
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 28, 2021
@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 28, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 28, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 28, 2021

I also changed the required check from pr-validation-temp to aspnetcore-ci

@wtgodbe wtgodbe mentioned this pull request Jan 28, 2021
Merged
@dougbu
Copy link
Contributor

dougbu commented Jan 28, 2021

I also changed the required check from pr-validation-temp to aspnetcore-ci

Think the release/2.1 protection rule can just be deleted. Looks like it matches the release/* rule. Right❔

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 28, 2021

Think the release/2.1 protection rule can just be deleted. Looks like it matches the release/* rule. Right❔

Agreed, looks the same to me. I just deleted it.

dougbu
dougbu approved these changes Jan 28, 2021
View reviewed changes
.azure/pipelines/pr-validation-temp.yml
jobName: Windows_Build
jobDisplayName: "Build only : Windows"
agentOs: Windows
buildArgs: '/p:SkipTests=true'
Copy link
Contributor

@dougbu dougbu Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this was ignored anyhow. See https://dev.azure.com/dnceng/public/_build/results?buildId=969282 and the warnings about $(BuildScriptArgs). Might have a bug in this branch's version of default-build.yml

Copy link
Contributor

@dougbu dougbu Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it. I'll put up a quick PR later today to fix it.

Copy link
Contributor

@dougbu dougbu Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#29737

@dougbu
Copy link
Contributor

dougbu commented Jan 28, 2021

One other point: Once #29037 and anything else in-progress drains from aspnetcore-pr-validation-temp, please delete the pipeline too

@wtgodbe
Copy link
Member Author

wtgodbe commented Jan 28, 2021

One other point: Once #29037 and anything else in-progress drains from aspnetcore-pr-validation-temp, please delete the pipeline too

I've just deleted it.

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 29, 2021
@dougbu dougbu added this to the 2.1.26 milestone Jan 29, 2021
@wtgodbe wtgodbe merged commit f40f5ac into release/2.1 Feb 10, 2021
@wtgodbe wtgodbe deleted the wtgodbe/RemovePRTemp branch February 10, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

2.1.26

Development

Successfully merging this pull request may close these issues.

2 participants

@wtgodbe @dougbu