Skip to content

Move artifacts block to bottom of win-arm64 leg #30634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2021
Merged

Move artifacts block to bottom of win-arm64 leg #30634

merged 1 commit into from
Mar 4, 2021

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 4, 2021

Because of the current state, the whole NuGetCommand gets passed as an artifact parameter to default-build.yml, which causes it to upload the whole build directory as an artifact (and skip the Push Visual Studio packages step entirely)

@wtgodbe wtgodbe requested a review from a team March 4, 2021 01:15
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 4, 2021
@wtgodbe wtgodbe merged commit 3b1fd90 into release/3.1 Mar 4, 2021
@wtgodbe wtgodbe deleted the wtgodbe/MoveBlock branch March 4, 2021 01:17
@JunTaoLuo
Copy link
Contributor

:shipit:

@dougbu
Copy link
Contributor

dougbu commented Mar 4, 2021

Oops, putting artifacts in the middle of the steps is nasty. Think I commended on this on @JunTaoLuo's PR but missed the impact (thought it just placed artifacts before steps) 🤦

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @JunTaoLuo @dougbu