Skip to content

Make trailers safer in TestHost #32633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021
Merged

Make trailers safer in TestHost #32633

merged 1 commit into from
May 13, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented May 13, 2021

Addresses #32561

I'm not sure this is a fix because I can't see where the problem is. But checking the trailers haven't been set to null should be done anyway for safety.

Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better than nothing, but I agree this is unlikely to be the source of intermittent failures.

@JamesNK JamesNK merged commit 9fa86b3 into main May 13, 2021
@JamesNK JamesNK deleted the jamesnk/testhost-nulltrailers branch May 13, 2021 03:03
@ghost ghost added this to the 6.0-preview5 milestone May 13, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants