-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add IResult implementations for more IActionResults #32647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IResult implementations for more IActionResults #32647
Conversation
@halter73 @davidfowl I would like to confirm the approach I am taking is how you were envisioning the implementation of these new If the approach its fine I will continue with the rest but there is a question, similar to MVC we will need to register singleton of each ActionResult like this aspnetcore/src/Mvc/Mvc.Core/src/DependencyInjection/MvcCoreServiceCollectionExtensions.cs Lines 245 to 259 in d8906c8
Where do you think is the best place to add these new addings in this particular case? |
f64ba95
to
07b6825
Compare
@halter73 I have added implementation for:
I will work on others tomorrow either on this PR or in a new one if this get accepted, thanks for reviewing :) |
07b6825
to
ef58304
Compare
ef58304
to
dc5c76d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
Thanks for the PR! |
Summary
These changes add necessary implementation to IActionResults that does not have it
Details
The IActionResults that are going to be worked on this PR are:
Task that needs to be done for this PR are:
Addresses #32565