Avoid adding CSS scope to elements in HEAD #32709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
javiercn
reviewed
May 15, 2021
Comment on lines
71
to
78
| var isInvalidTag = content.Contains("head") | ||
| || content.Contains("meta") | ||
| || content.Contains("title") | ||
| || content.Contains("link") | ||
| || content.Contains("base") | ||
| || content.Contains("script") | ||
| || content.Contains("style") | ||
| || content.Contains("html"); |
Member
There was a problem hiding this comment.
I believe these should be StringComparison.OrdinalIgnoreCase
javiercn
approved these changes
May 15, 2021
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Looks great!
Just a small touch up! I like that we didn't try something more complicated. Something like this is perfect since it will work most of the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #32542.